Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: third_party/crashpad/crashpad/util/misc/metrics.h

Issue 2710663006: Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7 (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/misc/metrics.h
diff --git a/third_party/crashpad/crashpad/util/misc/metrics.h b/third_party/crashpad/crashpad/util/misc/metrics.h
index fd2e120063a602c3668863fe137fb5ca106a6e77..f1c5731a94eb3c121774ac43e4eeee12ff06417f 100644
--- a/third_party/crashpad/crashpad/util/misc/metrics.h
+++ b/third_party/crashpad/crashpad/util/misc/metrics.h
@@ -130,6 +130,34 @@ class Metrics {
//! \brief The exception handler server started capturing an exception.
static void ExceptionEncountered();
+ //! \brief An important event in a handler process’ lifetime.
Ilya Sherman 2017/02/22 20:16:18 Please document that this is used to back an UMA h
Mark Mentovai 2017/02/22 20:27:47 Everything in this file is for UMA support. Do you
Ilya Sherman 2017/02/22 22:53:01 I'd generally lean toward yes, because not all dev
+ enum class LifetimeMilestone : int32_t {
+ //! \brief The handler process started.
+ kStarted = 0,
+
+ //! \brief The handler process exited normally and cleanly.
+ kExitedNormally,
+
+ //! \brief The handler process exited early, but was successful in
+ //! performing some non-default action on user request.
+ kExitedEarly,
+
+ //! \brief The handler process exited with a failure code.
+ kFailed,
+
+ //! \brief The handler process was forcibly terminated.
+ kTerminated,
+
+ //! \brief The handler process crashed.
+ kCrashed,
+
+ //! \brief The number of values in this enumeration; not a valid value.
+ kMaxValue
+ };
+
+ //! \brief Records a handler start/exit/crash event.
+ static void HandlerLifetimeMilestone(LifetimeMilestone milestone);
+
//! \brief The handler process crashed with the given exception code.
//!
//! This is currently only reported on Windows.

Powered by Google App Engine
This is Rietveld 408576698