Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7

third_party/crashpad/crashpad/util/misc/metrics.h

 // Copyright 2016 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 112 matching lines @@
 
   //! \brief The exception code for an exception was retrieved.
   //!
   //! These values are OS-specific, and correspond to
   //! MINIDUMP_EXCEPTION::ExceptionCode.
   static void ExceptionCode(uint32_t exception_code);
 
   //! \brief The exception handler server started capturing an exception.
   static void ExceptionEncountered();
 
+  //! \brief An important event in a handler process’ lifetime.

[Ilya Sherman, 2017/02/22 20:16:18]

Please document that this is used to back an UMA histogram, and should therefore
be treated as append-only.

[Mark Mentovai, 2017/02/22 20:27:47]

Everything in this file is for UMA support. Do you want to see that note on each
enum as boilerplate?

[Ilya Sherman, 2017/02/22 22:53:01]

I'd generally lean toward yes, because not all developers will otherwise realize
that this constraint is important, even if they realize that the file is related
to metrics.  But, I defer to your judgement on this point.

+  enum class LifetimeMilestone : int32_t {
+    //! \brief The handler process started.
+    kStarted = 0,
+
+    //! \brief The handler process exited normally and cleanly.
+    kExitedNormally,
+
+    //! \brief The handler process exited early, but was successful in
+    //!     performing some non-default action on user request.
+    kExitedEarly,
+
+    //! \brief The handler process exited with a failure code.
+    kFailed,
+
+    //! \brief The handler process was forcibly terminated.
+    kTerminated,
+
+    //! \brief The handler process crashed.
+    kCrashed,
+
+    //! \brief The number of values in this enumeration; not a valid value.
+    kMaxValue
+  };
+
+  //! \brief Records a handler start/exit/crash event.
+  static void HandlerLifetimeMilestone(LifetimeMilestone milestone);
+
   //! \brief The handler process crashed with the given exception code.
   //!
   //! This is currently only reported on Windows.
   static void HandlerCrashed(uint32_t exception_code);
 
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(Metrics);
 };
 
 }  // namespace crashpad
 
 #endif  // CRASHPAD_UTIL_MISC_METRICS_H_