Reland Stop MenuItemView from directly caching MenuController

Reland Stop MenuItemView from directly caching MenuController

This relands a change reviewed in: https://codereview.chromium.org/2684993009
With an update to the unittest to fix a memory leak that was only within the
test.

Revert "Revert of Stop MenuItemView From Directly Caching MenuController (patchset #1 id:1 of https://codereview.chromium.org/2684993009/ )"

This reverts commit b18851a60fd1a0820c00185bd660fc52bec31648.

TEST=MenuControllerTest.HostReceivesInputBeforeDestruction
BUG=691415
Review-Url: https://codereview.chromium.org/2710663004
Cr-Commit-Position: refs/heads/master@{#452055}
Committed: https://chromium.googlesource.com/chromium/src/+/99e51965aae5623c4d16975578802caf7b3c8ac9

[jonross, 2017-02-21 18:48:58]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-02-21 18:48:59]

Hey sky@,

Attempting to reland a previous change, with a fix to the unittest. PTAL

[sky, 2017-02-21 21:31:47]

LGTM

[jonross, 2017-02-21 21:31:56]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-02-21 21:34:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 23:39:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:39:05]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[jonross, 2017-02-21 23:56:05]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-02-21 23:58:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 02:05:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:05:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[jonross, 2017-02-22 14:46:45]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-02-22 14:46:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 15:20:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487774805662480,
"parent_rev": "48fd5b949faacbd387904d9844283bfcf1fe837a", "commit_rev":
"99e51965aae5623c4d16975578802caf7b3c8ac9"}

[commit-bot: I haz the power, 2017-02-22 15:20:48]

Description was changed from

==========
Reland Stop MenuItemView from directly caching MenuController

This relands a change reviewed in: https://codereview.chromium.org/2684993009
With an update to the unittest to fix a memory leak that was only within the
test.

Revert "Revert of Stop MenuItemView From Directly Caching MenuController
(patchset #1 id:1 of https://codereview.chromium.org/2684993009/ )"

This reverts commit b18851a60fd1a0820c00185bd660fc52bec31648.

TEST=MenuControllerTest.HostReceivesInputBeforeDestruction
BUG=691415
==========

to

==========
Reland Stop MenuItemView from directly caching MenuController

This relands a change reviewed in: https://codereview.chromium.org/2684993009
With an update to the unittest to fix a memory leak that was only within the
test.

Revert "Revert of Stop MenuItemView From Directly Caching MenuController
(patchset #1 id:1 of https://codereview.chromium.org/2684993009/ )"

This reverts commit b18851a60fd1a0820c00185bd660fc52bec31648.

TEST=MenuControllerTest.HostReceivesInputBeforeDestruction
BUG=691415

Review-Url: https://codereview.chromium.org/2710663004
Cr-Commit-Position: refs/heads/master@{#452055}
Committed:
https://chromium.googlesource.com/chromium/src/+/99e51965aae5623c4d1697557880...
==========

[commit-bot: I haz the power, 2017-02-22 15:20:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/99e51965aae5623c4d1697557880...