Make PendingSelection::calcVisibleSelection() to return SelectionInFlatTree

Make PendingSelection::calcVisibleSelection() to return SelectionInFlatTree

This patch makes |PendingSelection::calcVisibleSelection()| to return
|SelectionInFlatTree| to avoid using |setWithoutValidation()| as a preparation
of making |VisibleSelection| as immutable object for improving code health.

BUG=660320
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2710613002
Cr-Commit-Position: refs/heads/master@{#451748}
Committed: https://chromium.googlesource.com/chromium/src/+/c96ea05e8b2961eb5d57829018fea8821b57acfd

[yosin_UTC9, 2017-02-21 04:23:09]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 04:23:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-02-21 05:29:39]

Description was changed from

==========
2017-02-21T13:20:23

2017-02-21T13:20:15

BUG=
==========

to

==========
Make PendingSelection::calcVisibleSelection() to return SelectionInFlatTree

This patch makes |PendingSelection::calcVisibleSelection()| to return
|SelectionInFlatTree| to avoid using |setWithoutValidation()| as a preparation
of making |VisibleSelection| as immutable object for improving code health.

BUG=660320
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-02-21 05:29:55]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-02-21 05:29:55]

PTAL

[yoichio, 2017-02-21 05:37:27]

lgtm

[yosin_UTC9, 2017-02-21 05:37:36]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-21 05:37:38]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 05:37:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 07:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 07:13:22]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yosin_UTC9, 2017-02-21 08:05:28]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 08:05:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 10:54:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 10:54:31]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yosin_UTC9, 2017-02-21 12:29:51]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 12:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 13:08:19]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487680191612610, "parent_rev":
"6299cc1d8fc24c3fd382b6dbe615a58381b73af0", "commit_rev":
"c96ea05e8b2961eb5d57829018fea8821b57acfd"}

[commit-bot: I haz the power, 2017-02-21 13:08:55]

Description was changed from

==========
Make PendingSelection::calcVisibleSelection() to return SelectionInFlatTree

This patch makes |PendingSelection::calcVisibleSelection()| to return
|SelectionInFlatTree| to avoid using |setWithoutValidation()| as a preparation
of making |VisibleSelection| as immutable object for improving code health.

BUG=660320
TEST=n/a; no behavior changes
==========

to

==========
Make PendingSelection::calcVisibleSelection() to return SelectionInFlatTree

This patch makes |PendingSelection::calcVisibleSelection()| to return
|SelectionInFlatTree| to avoid using |setWithoutValidation()| as a preparation
of making |VisibleSelection| as immutable object for improving code health.

BUG=660320
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2710613002
Cr-Commit-Position: refs/heads/master@{#451748}
Committed:
https://chromium.googlesource.com/chromium/src/+/c96ea05e8b2961eb5d57829018fe...
==========

[commit-bot: I haz the power, 2017-02-21 13:08:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c96ea05e8b2961eb5d57829018fe...