Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2710603008: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
Patrick Monette
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file. Please help us to verify the added TEAM/COMPONENT or suggest the correct TEAM/COMPONENT in your OWNERS files. Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=pmonette@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2710603008 Cr-Commit-Position: refs/heads/master@{#452883} Committed: https://chromium.googlesource.com/chromium/src/+/4b09589a1780687bc09bcbf9c5f191f9cee6616d

Patch Set 1 #

Total comments: 4

Patch Set 2 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/conflicts/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/win/OWNERS View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/common/conflicts/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/conflicts/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-23 18:24:51 UTC) #2
Patrick Monette
Hi I think Internals>Core is better suited for all of those. Thanks for doing this! ...
3 years, 10 months ago (2017-02-24 17:04:24 UTC) #3
ymzhang1
Thanks for helping! https://codereview.chromium.org/2710603008/diff/1/chrome/browser/conflicts/OWNERS File chrome/browser/conflicts/OWNERS (right): https://codereview.chromium.org/2710603008/diff/1/chrome/browser/conflicts/OWNERS#newcode4 chrome/browser/conflicts/OWNERS:4: # COMPONENT: UI>Browser On 2017/02/24 17:04:24, ...
3 years, 10 months ago (2017-02-24 18:15:58 UTC) #4
Patrick Monette
lgtm
3 years, 10 months ago (2017-02-24 18:29:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710603008/20001
3 years, 10 months ago (2017-02-24 18:32:46 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 18:50:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b09589a1780687bc09bcbf9c5f1...

Powered by Google App Engine
This is Rietveld 408576698