[wasm] Move compilation-related methods to CompilationHelper in wasm-module.cc.

[wasm] Move compilation-related methods to CompilationHelper in wasm-module.cc.

This is a refactoring CL in preparation for implementing asynchronous compilation.
It moves all the compilation-related functionality to a helper class which will
make it easier to split into background and foreground tasks which is needed
for concurrent/synchronous execution of compilation.

R=clemensh@chromium.org,ahaas@chromium.org
BUG=v8:6003
Review-Url: https://codereview.chromium.org/2710603006
Cr-Commit-Position: refs/heads/master@{#43413}
Committed: https://chromium.googlesource.com/v8/v8/+/d2a7bcfcf70215d10173b147de82cceaa0533cf7

[titzer, 2017-02-22 17:06:31]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 17:06:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 17:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 17:27:47]

Dry run: This issue passed the CQ dry run.

[ahaas, 2017-02-24 11:59:10]

lgtm

https://codereview.chromium.org/2710603006/diff/1/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2710603006/diff/1/src/wasm/wasm-module.cc#new...
src/wasm/wasm-module.cc:149: const int kBufferSize = 50;
Nit, I think we could use a lower bound here.

[titzer, 2017-02-24 12:58:35]

On 2017/02/24 11:59:10, ahaas wrote:
> lgtm
> 
> https://codereview.chromium.org/2710603006/diff/1/src/wasm/wasm-module.cc
> File src/wasm/wasm-module.cc (right):
> 
>
https://codereview.chromium.org/2710603006/diff/1/src/wasm/wasm-module.cc#new...
> src/wasm/wasm-module.cc:149: const int kBufferSize = 50;
> Nit, I think we could use a lower bound here.

Done.

[titzer, 2017-02-24 12:58:44]

The CQ bit was checked by titzer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 12:58:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 13:20:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 13:20:08]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-02-24 13:26:11]

The CQ bit was checked by titzer@chromium.org

[titzer, 2017-02-24 13:26:11]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2710603006/#ps20001
(title: "Smaller buffer")

[commit-bot: I haz the power, 2017-02-24 13:26:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 13:27:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487942771034190,
"parent_rev": "45dfd76a9c38e6a872ac14e62faee2ace1f1dbac", "commit_rev":
"d2a7bcfcf70215d10173b147de82cceaa0533cf7"}

[commit-bot: I haz the power, 2017-02-24 13:28:00]

Description was changed from

==========
[wasm] Move compilation-related methods to CompilationHelper in wasm-module.cc.

This is a refactoring CL in preparation for implementing asynchronous
compilation.
It moves all the compilation-related functionality to a helper class which will
make it easier to split into background and foreground tasks which is needed
for concurrent/synchronous execution of compilation.

R=clemensh@chromium.org,ahaas@chromium.org
BUG=v8:6003
==========

to

==========
[wasm] Move compilation-related methods to CompilationHelper in wasm-module.cc.

This is a refactoring CL in preparation for implementing asynchronous
compilation.
It moves all the compilation-related functionality to a helper class which will
make it easier to split into background and foreground tasks which is needed
for concurrent/synchronous execution of compilation.

R=clemensh@chromium.org,ahaas@chromium.org
BUG=v8:6003

Review-Url: https://codereview.chromium.org/2710603006
Cr-Commit-Position: refs/heads/master@{#43413}
Committed:
https://chromium.googlesource.com/v8/v8/+/d2a7bcfcf70215d10173b147de82cceaa05...
==========

[commit-bot: I haz the power, 2017-02-24 13:28:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d2a7bcfcf70215d10173b147de82cceaa05...