Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 2710603002: Adds a test for setting empty composition text. (Closed)

Created:
3 years, 10 months ago by Shu Chen
Modified:
3 years, 10 months ago
Reviewers:
Azure Wei
CC:
chromium-reviews, extensions-reviews_chromium.org, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds a test for setting empty composition text. BUG=682199 Review-Url: https://codereview.chromium.org/2710603002 Cr-Commit-Position: refs/heads/master@{#451708} Committed: https://chromium.googlesource.com/chromium/src/+/c49d32e2554c23beb02be20061c0b9784476fe98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -24 lines) Patch
M chrome/browser/ui/views/ime/input_ime_apitest_nonchromeos.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/input_ime_nonchromeos/background.js View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.h View 2 chunks +8 lines, -8 lines 0 comments Download
M ui/base/ime/dummy_text_input_client.cc View 1 chunk +5 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Shu Chen
3 years, 10 months ago (2017-02-21 03:37:15 UTC) #3
Azure Wei
lgtm
3 years, 10 months ago (2017-02-21 03:39:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710603002/1
3 years, 10 months ago (2017-02-21 06:14:30 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 06:20:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c49d32e2554c23beb02be20061c0...

Powered by Google App Engine
This is Rietveld 408576698