Selection API: add removeRange().

Selection API: add removeRange().

Approved Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OnBuqLuHLeI

This CL adds selection/removeRange.html to web-platform-tests.

BUG=692881
Review-Url: https://codereview.chromium.org/2710593009
Cr-Commit-Position: refs/heads/master@{#452965}
Committed: https://chromium.googlesource.com/chromium/src/+/e54bc779bf060c6704d4a581ee7137bb268c6b7c

[tkent, 2017-02-24 08:31:05]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 08:31:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 10:03:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 10:03:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tkent, 2017-02-24 12:08:18]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 12:08:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 13:22:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 13:22:12]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-24 14:05:09]

Description was changed from

==========
Selection API: add removeRange().

BUG=
==========

to

==========
Selection API: add removeRange().

BUG=391673
==========

[tkent, 2017-02-24 14:06:05]

Description was changed from

==========
Selection API: add removeRange().

BUG=391673
==========

to

==========
Selection API: add removeRange().

Approved Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OnBuqLuHLeI

BUG=692881
==========

[tkent, 2017-02-24 14:06:33]

Description was changed from

==========
Selection API: add removeRange().

Approved Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OnBuqLuHLeI

BUG=692881
==========

to

==========
Selection API: add removeRange().

Approved Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OnBuqLuHLeI

This CL adds selection/removeRange.html to web-platform-tests.

BUG=692881
==========

[tkent, 2017-02-24 14:06:56]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-24 14:06:57]

yosin@, yoichio@, would you review this please?

[tkent, 2017-02-24 14:08:03]

Patchset #1 (id:1) has been deleted

[yosin_UTC9, 2017-02-24 14:47:55]

lgtm

https://codereview.chromium.org/2710593009/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2710593009/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:588: if (range ==
primaryRangeOrNull())
nit: I prefer early-return style:

if (range != primaryRangeOrNull())
  return;
frame()->selection().clear();

[tkent, 2017-02-24 17:44:12]

https://codereview.chromium.org/2710593009/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/DOMSelection.cpp (right):

https://codereview.chromium.org/2710593009/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/DOMSelection.cpp:588: if (range ==
primaryRangeOrNull())
On 2017/02/24 at 14:47:55, yosin_UTC9 wrote:
> nit: I prefer early-return style:
> 
> if (range != primaryRangeOrNull())
>   return;
> frame()->selection().clear();

I prefer early-return in general.  However, not-early-return is simpler in this
case.

[tkent, 2017-02-24 17:44:18]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-02-24 17:44:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 17:51:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 17:51:51]

Failed to apply patch for
third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json:54766
  error: third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json: patch does
not apply

Patch:       third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
Index: third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
diff --git a/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
b/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
index
c4464d803268202ebfc759e15cea5fd3f28f9345..346ad9f319b68b63233d9729672cf02a83304999
100644
--- a/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
+++ b/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
@@ -49916,6 +49916,12 @@
      {}
     ]
    ],
+   "selection/removeRange.html": [
+    [
+     "/selection/removeRange.html",
+     {}
+    ]
+   ],
    "selection/selectAllChildren.html": [
     [
      "/selection/selectAllChildren.html",
@@ -54766,7 +54772,7 @@
    "support"
   ],
   "./MANIFEST.json": [
-   "9308ccf7a833b8f021128cebbb59c78a5b03a9ae",
+   "49ed1806559e344b58eda2479a32992e41b5ecdd",
    "support"
   ],
   "./README.md": [
@@ -83265,6 +83271,10 @@
    "23385a72a586db288b282eb251f9384048532666",
    "testharness"
   ],
+  "selection/removeRange.html": [
+   "9a4f6531d510b781edd02acae9ffd2453bf48423",
+   "testharness"
+  ],
   "selection/selectAllChildren.html": [
    "1951e6d34c7959c038146efde2d49a7898eaee29",
    "testharness"

[tkent, 2017-02-24 18:00:38]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 18:01:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:30:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 19:30:09]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-02-24 22:27:58]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-02-24 22:27:58]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2710593009/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-24 22:28:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 22:41:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487975278542190,
"parent_rev": "6402a68da4b3b959e61f2c977d03dcf80e2b213f", "commit_rev":
"e54bc779bf060c6704d4a581ee7137bb268c6b7c"}

[commit-bot: I haz the power, 2017-02-24 22:42:15]

Description was changed from

==========
Selection API: add removeRange().

Approved Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OnBuqLuHLeI

This CL adds selection/removeRange.html to web-platform-tests.

BUG=692881
==========

to

==========
Selection API: add removeRange().

Approved Intent-to-Ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OnBuqLuHLeI

This CL adds selection/removeRange.html to web-platform-tests.

BUG=692881

Review-Url: https://codereview.chromium.org/2710593009
Cr-Commit-Position: refs/heads/master@{#452965}
Committed:
https://chromium.googlesource.com/chromium/src/+/e54bc779bf060c6704d4a581ee71...
==========

[commit-bot: I haz the power, 2017-02-24 22:42:16]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e54bc779bf060c6704d4a581ee71...