Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2710593005: Add .gitignore files in build/ and third_party/ (Closed)

Created:
3 years, 10 months ago by kjellander_chromium
Modified:
3 years, 10 months ago
CC:
charujain2, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add .gitignore files in build/ and third_party/ Having this, a lot of wasted bandwidth is avoided for projects that use these directories as DEPS entries, since the top-level Chromium .gitignore doesn't exist in those cases. The src/ repo already contained 51 other .gitignore files anyway, so it's hard to claim the top-level file has to be the only one. BUG=690010 Review-Url: https://codereview.chromium.org/2710593005 Cr-Commit-Position: refs/heads/master@{#452167} Committed: https://chromium.googlesource.com/chromium/src/+/68d02518d39937443244001624fa500e00aad408

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -213 lines) Patch
M .gitignore View 2 chunks +2 lines, -213 lines 0 comments Download
A build/.gitignore View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/.gitignore View 1 chunk +199 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
kjellander_chromium
3 years, 10 months ago (2017-02-22 14:13:07 UTC) #5
Paweł Hajdan Jr.
LGTM
3 years, 10 months ago (2017-02-22 16:27:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710593005/20001
3 years, 10 months ago (2017-02-22 19:22:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/370390)
3 years, 10 months ago (2017-02-22 19:31:01 UTC) #12
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-22 19:43:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710593005/20001
3 years, 10 months ago (2017-02-22 19:45:17 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 19:52:59 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/68d02518d39937443244001624fa...

Powered by Google App Engine
This is Rietveld 408576698