cc: Fix const value pattern by replacing it by non-const or reference.

cc: Fix const value pattern by replacing it by non-const or reference.

This patch changes cc to ensure that we don't have a const value
parameters. These are replaced by either non-const value or by
reference to const depending on the situation.

R=danakj@chromium.org
BUG=691787
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2710593003
Cr-Commit-Position: refs/heads/master@{#452177}
Committed: https://chromium.googlesource.com/chromium/src/+/0e5ce3e075b6bdde16328a4f280a1f8ba8621a2f

[vmpstr, 2017-02-21 18:24:51]

Description was changed from

==========
cc: Fix const value pattern by replacing it by non-const or reference.

This patch changes cc to ensure that we don't have a const value
parameters. These are replaced by either non-const value or by
reference to const depending on the situation.

R=danakj@chromium.org
BUG=691787
==========

to

==========
cc: Fix const value pattern by replacing it by non-const or reference.

This patch changes cc to ensure that we don't have a const value
parameters. These are replaced by either non-const value or by
reference to const depending on the situation.

R=danakj@chromium.org
BUG=691787
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[vmpstr, 2017-02-21 18:25:54]

Please take a look.

[danakj, 2017-02-21 20:20:30]

LGTM

https://codereview.chromium.org/2710593003/diff/1/cc/debug/rasterize_and_reco...
File cc/debug/rasterize_and_record_benchmark_impl.cc (right):

https://codereview.chromium.org/2710593003/diff/1/cc/debug/rasterize_and_reco...
cc/debug/rasterize_and_record_benchmark_impl.cc:73: const Region& invalidation)
o geez

https://codereview.chromium.org/2710593003/diff/1/cc/input/page_scale_animati...
File cc/input/page_scale_animation.h (right):

https://codereview.chromium.org/2710593003/diff/1/cc/input/page_scale_animati...
cc/input/page_scale_animation.h:24: bool _use_anchor,
these variable names tho.. can fix them

[vmpstr, 2017-02-21 20:29:42]

https://codereview.chromium.org/2710593003/diff/1/cc/input/page_scale_animati...
File cc/input/page_scale_animation.h (right):

https://codereview.chromium.org/2710593003/diff/1/cc/input/page_scale_animati...
cc/input/page_scale_animation.h:24: bool _use_anchor,
On 2017/02/21 20:20:29, danakj wrote:
> these variable names tho.. can fix them

Done.

[vmpstr, 2017-02-21 20:29:45]

The CQ bit was checked by vmpstr@chromium.org

[vmpstr, 2017-02-21 20:29:46]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2710593003/#ps20001
(title: "update rebase")

[commit-bot: I haz the power, 2017-02-21 20:31:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 22:37:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 22:37:45]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[vmpstr, 2017-02-22 00:21:26]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-22 00:22:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 02:26:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 02:26:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[vmpstr, 2017-02-22 18:49:18]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2017-02-22 18:50:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 20:09:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487789358012950,
"parent_rev": "a06dc6c5060618f557be9310cf37080000b77db3", "commit_rev":
"0e5ce3e075b6bdde16328a4f280a1f8ba8621a2f"}

[commit-bot: I haz the power, 2017-02-22 20:09:46]

Description was changed from

==========
cc: Fix const value pattern by replacing it by non-const or reference.

This patch changes cc to ensure that we don't have a const value
parameters. These are replaced by either non-const value or by
reference to const depending on the situation.

R=danakj@chromium.org
BUG=691787
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Fix const value pattern by replacing it by non-const or reference.

This patch changes cc to ensure that we don't have a const value
parameters. These are replaced by either non-const value or by
reference to const depending on the situation.

R=danakj@chromium.org
BUG=691787
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2710593003
Cr-Commit-Position: refs/heads/master@{#452177}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e5ce3e075b6bdde16328a4f280a...
==========

[commit-bot: I haz the power, 2017-02-22 20:09:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0e5ce3e075b6bdde16328a4f280a...