Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have code to check negati…

Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have code to check negative offsets.

Range::checkNodeWOffset() produces IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

Also, setBaseAndExtent(null, -1, ...) doesn't throw an IndexSizeError. This is
consistent with a behavior that setBaseAndExtent(null, 10000, ...) doesn't throw.
The offset argument should be unsigned actually, and we can't check offset
validity for null node.

BUG=683066
Review-Url: https://codereview.chromium.org/2710593002
Cr-Commit-Position: refs/heads/master@{#451700}
Committed: https://chromium.googlesource.com/chromium/src/+/78f6af0ff4c8891082f4b6b366ec70d85d528cf8

[tkent, 2017-02-21 01:49:33]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 01:49:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-21 01:58:59]

Description was changed from

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() calls in these functions produce IndexSizeError for
negative offsets. These code was redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset is
specified, the function throws InvalidNodeTypeErorr instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

BUG=683066
==========

to

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() can produce IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset
are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

BUG=683066
==========

[tkent, 2017-02-21 02:29:44]

Description was changed from

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() can produce IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset
are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

BUG=683066
==========

to

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() produces IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset
are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

BUG=683066
==========

[commit-bot: I haz the power, 2017-02-21 03:01:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 03:01:06]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-02-21 03:21:17]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 03:21:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-02-21 03:23:18]

Description was changed from

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() produces IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset
are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

BUG=683066
==========

to

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() produces IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset
are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

Also, setBaseAndExtent(null, -1, ...) doesn't throw an IndexSizeError. This is
consistent with a behavior that setBaseAndExtent(null, 10000, ...) doesn't
throw.

BUG=683066
==========

[tkent, 2017-02-21 03:23:27]

Patchset #1 (id:1) has been deleted

[tkent, 2017-02-21 03:24:24]

Description was changed from

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() produces IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset
are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

Also, setBaseAndExtent(null, -1, ...) doesn't throw an IndexSizeError. This is
consistent with a behavior that setBaseAndExtent(null, 10000, ...) doesn't
throw.

BUG=683066
==========

to

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() produces IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset
are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

Also, setBaseAndExtent(null, -1, ...) doesn't throw an IndexSizeError. This is
consistent with a behavior that setBaseAndExtent(null, 10000, ...) doesn't
throw.
The offset argument should be unsigned actually, and we can't check offset
validity for null node.

BUG=683066
==========

[tkent, 2017-02-21 03:25:35]

tkent@chromium.org changed reviewers:
+ yoichio@chromium.org, yosin@chromium.org

[tkent, 2017-02-21 03:25:35]

yoichio@, yosin@, would you review this please?

[tkent, 2017-02-21 03:26:44]

https://codereview.chromium.org/2710593002/diff/10001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt
(right):

https://codereview.chromium.org/2710593002/diff/10001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/extend-expected.txt:4: Success:
s.extend(span2.firstChild, -1) raised IndexSizeError: Failed to execute 'extend'
on 'Selection': The offset -1 is larger than or equal to the node's length (3)..
This message might make you crazy.  I'll fix it in a following CL.

[yosin_UTC9, 2017-02-21 03:34:55]

lgtm

Good catch!

[yosin_UTC9, 2017-02-21 03:35:00]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-02-21 03:35:02]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-02-21 03:35:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-21 04:36:17]

CQ is committing da patch.

Bot data: {"patchset_id": 10001, "attempt_start_ts": 1487648102757080,
"parent_rev": "a6c107d90f66410de1d944109e2cce930142fdd7", "commit_rev":
"78f6af0ff4c8891082f4b6b366ec70d85d528cf8"}

[commit-bot: I haz the power, 2017-02-21 04:37:12]

Description was changed from

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() produces IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset
are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

Also, setBaseAndExtent(null, -1, ...) doesn't throw an IndexSizeError. This is
consistent with a behavior that setBaseAndExtent(null, 10000, ...) doesn't
throw.
The offset argument should be unsigned actually, and we can't check offset
validity for null node.

BUG=683066
==========

to

==========
Selection API: collapse(), setBaseAndExtent(), and extend() don't need to have
code to check negative offsets.

Range::checkNodeWOffset() produces IndexSizeError for negative offsets.
Code to check negative offsets in these functions were redundant.

This CL changes behavior for DOCTYPE. If a DOCTYPE node and a negative offset
are
specified, the functions throw InvalidNodeTypeError instead of
IndexSizeError. This fixes 111 tests in external/wpt/selection/.

Also, setBaseAndExtent(null, -1, ...) doesn't throw an IndexSizeError. This is
consistent with a behavior that setBaseAndExtent(null, 10000, ...) doesn't
throw.
The offset argument should be unsigned actually, and we can't check offset
validity for null node.

BUG=683066

Review-Url: https://codereview.chromium.org/2710593002
Cr-Commit-Position: refs/heads/master@{#451700}
Committed:
https://chromium.googlesource.com/chromium/src/+/78f6af0ff4c8891082f4b6b366ec...
==========

[commit-bot: I haz the power, 2017-02-21 04:37:13]

Committed patchset #1 (id:10001) as
https://chromium.googlesource.com/chromium/src/+/78f6af0ff4c8891082f4b6b366ec...