Create Android Studio chromium style configuration.

Create Android Studio chromium style configuration.

The Android Studio Style configuration does not match the checkstyle
configuration, which causes import order to be wrong. The configuration
is specified here:
//tools/android/checkstyle/chromium-style-5.0.xml
under ImportOrder.

This CL copies the style configuration from the Android repository,
but changes it so that it matches what we have in checkstyle.

It also updates the Android Studio documentation to point to the
new file, and adds the new content and the documentation to the
watchlist for Android Studio in addition to updating the error message
from checkstyle to now refer to the new style file.

BUG=None

Review-Url: https://codereview.chromium.org/2710573004
Cr-Commit-Position: refs/heads/master@{#453542}
Committed: https://chromium.googlesource.com/chromium/src/+/6e560d0309ec9a4016f07b1da296f8f84625ec2e

[nyquist, 2017-02-22 00:34:17]

Description was changed from

==========
Create Android Studio chromium style configuration.

The Android Studio Style configuration does not match the checkstyle
configuration, which causes import order to be wrong.

This CL copies the style configuration from the Android repository,
but changes it so that it matches what we have in checkstyle.

It also updates the Android Studio documentation to point to the
new file.

BUG=None
==========

to

==========
Create Android Studio chromium style configuration.

The Android Studio Style configuration does not match the checkstyle
configuration, which causes import order to be wrong. The configuration
is specified here:
//tools/android/checkstyle/chromium-style-5.0.xml
under ImportOrder.

This CL copies the style configuration from the Android repository,
but changes it so that it matches what we have in checkstyle.

It also updates the Android Studio documentation to point to the
new file, and adds the new content and the documentation to the
watchlist for Android Studio.

BUG=None
==========

[nyquist, 2017-02-22 00:35:18]

nyquist@chromium.org changed reviewers:
+ wnwen@chromium.org

[nyquist, 2017-02-22 00:35:18]

wnwen: PTAL

Wasn't sure whether to add you or agrieve@.

[nyquist, 2017-02-22 00:45:43]

nyquist@chromium.org changed reviewers:
+ jbudorick@chromium.org

[nyquist, 2017-02-22 00:45:44]

jbudorick: Realized I also need OWNERS review... But feel free to review for
reals.

The only change to the style itself is from patch set 1 to 2.

[nyquist, 2017-02-22 00:59:31]

Description was changed from

==========
Create Android Studio chromium style configuration.

The Android Studio Style configuration does not match the checkstyle
configuration, which causes import order to be wrong. The configuration
is specified here:
//tools/android/checkstyle/chromium-style-5.0.xml
under ImportOrder.

This CL copies the style configuration from the Android repository,
but changes it so that it matches what we have in checkstyle.

It also updates the Android Studio documentation to point to the
new file, and adds the new content and the documentation to the
watchlist for Android Studio.

BUG=None
==========

to

==========
Create Android Studio chromium style configuration.

The Android Studio Style configuration does not match the checkstyle
configuration, which causes import order to be wrong. The configuration
is specified here:
//tools/android/checkstyle/chromium-style-5.0.xml
under ImportOrder.

This CL copies the style configuration from the Android repository,
but changes it so that it matches what we have in checkstyle.

It also updates the Android Studio documentation to point to the
new file, and adds the new content and the documentation to the
watchlist for Android Studio in addition to updating the error message
from checkstyle to now refer to the new style file.

BUG=None
==========

[nyquist, 2017-02-22 00:59:44]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 01:01:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 03:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 03:06:55]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)

[nyquist, 2017-02-23 00:32:45]

nyquist@chromium.org changed reviewers:
+ agrieve@chromium.org

[nyquist, 2017-02-23 00:32:46]

agrieve: Turns out wnwen@ is unavailable. Can you take a look?

[jbudorick, 2017-02-23 00:35:44]

On 2017/02/22 00:45:44, nyquist wrote:
> jbudorick: Realized I also need OWNERS review... But feel free to review for
> reals.
> 
> The only change to the style itself is from patch set 1 to 2.

This looks pretty reasonable to me, though I didn't look *that* carefully at
ChromiumStyle.xml and haven't used Studio for chromium at all. I'm happy to
stamp this after agrieve or wnwen takes a look, though.

[jbudorick, 2017-02-23 00:51:40]

er, just saw your comment about the change being the 1->2 diff

https://codereview.chromium.org/2710573004/diff/20001/tools/android/android_s...
File tools/android/android_studio/ChromiumStyle.xml (right):

https://codereview.chromium.org/2710573004/diff/20001/tools/android/android_s...
tools/android/android_studio/ChromiumStyle.xml:42: <package name="com"
withSubpackages="true" static="false" />
Is it smart enough to have this not match com.google.android.apps.chrome?

[agrieve, 2017-02-23 01:41:36]

lgtm

https://codereview.chromium.org/2710573004/diff/100001/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/2710573004/diff/100001/WATCHLISTS#newcode71
WATCHLISTS:71: '|tools/android/android_studio'
hmm, perhaps we should move build/android/gradle under tools eventually as
well...

[nyquist, 2017-02-24 07:26:27]

https://codereview.chromium.org/2710573004/diff/100001/WATCHLISTS
File WATCHLISTS (right):

https://codereview.chromium.org/2710573004/diff/100001/WATCHLISTS#newcode71
WATCHLISTS:71: '|tools/android/android_studio'
On 2017/02/23 01:41:36, agrieve wrote:
> hmm, perhaps we should move build/android/gradle under tools eventually as
> well...

Yeah, I guess that might make sense. I guess it depends on how much part of
build it is and how much part of tool it is. Right not it does feel more like
//tool material.

[Peter Wen, 2017-02-27 20:28:47]

lgtm

Thanks for adding this!

[nyquist, 2017-02-27 22:14:59]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2017-02-27 22:15:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 22:25:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 22:25:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbudorick, 2017-02-27 22:27:43]

lgtm stamp

[nyquist, 2017-02-28 07:46:03]

https://codereview.chromium.org/2710573004/diff/20001/tools/android/android_s...
File tools/android/android_studio/ChromiumStyle.xml (right):

https://codereview.chromium.org/2710573004/diff/20001/tools/android/android_s...
tools/android/android_studio/ChromiumStyle.xml:42: <package name="com"
withSubpackages="true" static="false" />
On 2017/02/23 00:51:40, jbudorick wrote:
> Is it smart enough to have this not match com.google.android.apps.chrome?

Is such a thing even possible? Yes, it is!

[nyquist, 2017-02-28 07:46:14]

The CQ bit was checked by nyquist@chromium.org

[commit-bot: I haz the power, 2017-02-28 07:46:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 07:50:03]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488267974880870,
"parent_rev": "1eaf120fcf6eff6426a8522de27eb3b204b1b5f9", "commit_rev":
"6e560d0309ec9a4016f07b1da296f8f84625ec2e"}

[commit-bot: I haz the power, 2017-02-28 07:50:41]

Description was changed from

==========
Create Android Studio chromium style configuration.

The Android Studio Style configuration does not match the checkstyle
configuration, which causes import order to be wrong. The configuration
is specified here:
//tools/android/checkstyle/chromium-style-5.0.xml
under ImportOrder.

This CL copies the style configuration from the Android repository,
but changes it so that it matches what we have in checkstyle.

It also updates the Android Studio documentation to point to the
new file, and adds the new content and the documentation to the
watchlist for Android Studio in addition to updating the error message
from checkstyle to now refer to the new style file.

BUG=None
==========

to

==========
Create Android Studio chromium style configuration.

The Android Studio Style configuration does not match the checkstyle
configuration, which causes import order to be wrong. The configuration
is specified here:
//tools/android/checkstyle/chromium-style-5.0.xml
under ImportOrder.

This CL copies the style configuration from the Android repository,
but changes it so that it matches what we have in checkstyle.

It also updates the Android Studio documentation to point to the
new file, and adds the new content and the documentation to the
watchlist for Android Studio in addition to updating the error message
from checkstyle to now refer to the new style file.

BUG=None

Review-Url: https://codereview.chromium.org/2710573004
Cr-Commit-Position: refs/heads/master@{#453542}
Committed:
https://chromium.googlesource.com/chromium/src/+/6e560d0309ec9a4016f07b1da296...
==========

[commit-bot: I haz the power, 2017-02-28 07:50:42]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/6e560d0309ec9a4016f07b1da296...