Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2710563003: Worker: Fix wrong comment in InProcessWorkerObjectProxy (Closed)

Created:
3 years, 10 months ago by nhiroki
Modified:
3 years, 10 months ago
Reviewers:
falken
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Fix wrong comment in InProcessWorkerObjectProxy This wrong comment looks trivial but very confusing because ThreadedMessagingProxyBase lives on the main thread, while ThreadedObjectProxyBase lives on a worker thread. BUG=673711 Review-Url: https://codereview.chromium.org/2710563003 Cr-Commit-Position: refs/heads/master@{#451758} Committed: https://chromium.googlesource.com/chromium/src/+/18959bb68b0d32d7ff551b82aaaa9817154146f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
nhiroki
PTAL
3 years, 10 months ago (2017-02-21 08:12:25 UTC) #3
falken
On 2017/02/21 08:12:25, nhiroki wrote: > PTAL LGTM
3 years, 10 months ago (2017-02-21 08:37:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710563003/1
3 years, 10 months ago (2017-02-21 08:52:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/394058)
3 years, 10 months ago (2017-02-21 11:13:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710563003/1
3 years, 10 months ago (2017-02-21 13:20:16 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-21 14:42:54 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18959bb68b0d32d7ff551b82aaaa...

Powered by Google App Engine
This is Rietveld 408576698