Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 2710513002: 📰 Always hide articles header when alone (Closed)

Created:
3 years, 10 months ago by dgn
Modified:
3 years, 10 months ago
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

📰 Always hide articles header when alone Remove the small screen restriction on hiding the "Articles for you" header when the section is the only one displayed. BUG=694238 Review-Url: https://codereview.chromium.org/2710513002 Cr-Commit-Position: refs/heads/master@{#451623} Committed: https://chromium.googlesource.com/chromium/src/+/d0971b6cdd84a9f800da61d0b7b682a5fa4b61f5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -38 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java View 3 chunks +1 line, -8 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java View 8 chunks +12 lines, -29 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgn
PTAL
3 years, 10 months ago (2017-02-20 13:34:28 UTC) #2
Michael van Ouwerkerk
lgtm
3 years, 10 months ago (2017-02-20 14:10:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710513002/1
3 years, 10 months ago (2017-02-20 14:20:29 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 14:26:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d0971b6cdd84a9f800da61d0b7b6...

Powered by Google App Engine
This is Rietveld 408576698