[ObjC ARC] Converts ios/chrome/browser/payments:payments to ARC.

[ObjC ARC] Converts ios/chrome/browser/payments:payments to ARC.

Automatically generated ARCMigrate commit
Notable issues:
- Removed multiple delegate getter/setter/ivar combos with synthesize
- Fixed memory management in several blocks, for example:
 __weak ShippingOptionSelectionCoordinator* weakSelf = self;
  dispatch_after(
      dispatch_time(DISPATCH_TIME_NOW,
                    static_cast<int64_t>(0.2 * NSEC_PER_SEC)),
      dispatch_get_main_queue(), ^{
        ShippingOptionSelectionCoordinator* strongSelf = weakSelf;
        // Early return if the coordinator has been deallocated.
        if (!strongSelf)
          return;
        [_viewController setIsLoading:YES];
}

last line retains self through dereferenced ivar. Also further in the same block:

        [_delegate shippingOptionSelectionCoordinator:self  didSelectShippingOption:shippingOption];

direct reference to |self|


* In PaymentRequestViewController the following ivars are now strong: 
  PriceItem* _paymentSummaryItem;
  ShippingAddressItem* _selectedShippingAddressItem;
  CollectionViewTextItem* _selectedShippingOptionItem;
  PaymentMethodItem* _selectedPaymentMethodItem;

* For multiple view controllers with errorMessage property, it was changed from assign to copy as this seems to reflect de-facto usage. 

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2710493006
Cr-Commit-Position: refs/heads/master@{#452891}
Committed: https://chromium.googlesource.com/chromium/src/+/9c1d6844450a80766c882b007587f37e7b3e429d

[stkhapugin, 2017-02-21 13:52:15]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 13:52:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-02-21 15:03:36]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/payments:payments to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/payments:payments to ARC.

Automatically generated ARCMigrate commit
Notable issues:
- Removed multiple delegate getter/setter/ivar combos with synthesize
- Fixed memory management in several blocks, for example:
 __weak ShippingOptionSelectionCoordinator* weakSelf = self;
  dispatch_after(
      dispatch_time(DISPATCH_TIME_NOW,
                    static_cast<int64_t>(0.2 * NSEC_PER_SEC)),
      dispatch_get_main_queue(), ^{
        ShippingOptionSelectionCoordinator* strongSelf = weakSelf;
        // Early return if the coordinator has been deallocated.
        if (!strongSelf)
          return;
        [_viewController setIsLoading:YES];
}

last line retains self through dereferenced ivar. Also further in the same
block:

        [_delegate shippingOptionSelectionCoordinator:self 
didSelectShippingOption:shippingOption];

direct reference to |self|


* In PaymentRequestViewController the following ivars are now strong: 
  PriceItem* _paymentSummaryItem;
  ShippingAddressItem* _selectedShippingAddressItem;
  CollectionViewTextItem* _selectedShippingOptionItem;
  PaymentMethodItem* _selectedPaymentMethodItem;

* For multiple view controllers with errorMessage property, it was changed from
assign to copy as this seems to reflect de-facto usage. 

BUG=624363
TEST=None
==========

[stkhapugin, 2017-02-21 15:12:21]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-21 15:12:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-02-21 16:25:24]

stkhapugin@chromium.org changed reviewers:
+ marq@chromium.org, sdefresne@chromium.org

[stkhapugin, 2017-02-21 16:25:25]

PTAL. I made more manual changes than usual so two reviewers.

[sdefresne, 2017-02-21 17:22:35]

lgtm

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_coordinator.mm (right):

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_coordinator.mm:40:
base_view_controller_(base_view_controller){};
nit: remove trailing ;

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_coordinator.mm:143: -
(instancetype)initWithBaseViewController:(UIViewController*)viewController {
maybe remove this method as you're just forwarding to the base class now

[commit-bot: I haz the power, 2017-02-21 17:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-21 17:33:18]

Dry run: This issue passed the CQ dry run.

[marq (ping after 24h), 2017-02-22 11:55:58]

marq@chromium.org changed reviewers:
+ mahmadi@chromium.org

[marq (ping after 24h), 2017-02-22 11:55:59]

+mahmadi FYI

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_method_selection_coordinator.mm
(right):

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_method_selection_coordinator.mm:71: if
(!strongSelf)
Nit: No need to early return here.

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_coordinator.mm (right):

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_coordinator.mm:143: -
(instancetype)initWithBaseViewController:(UIViewController*)viewController {
On 2017/02/21 17:22:35, sdefresne wrote:
> maybe remove this method as you're just forwarding to the base class now

+1

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/shipping_address_selection_coordinator.mm
(right):

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/shipping_address_selection_coordinator.mm:87: //
Early return if the coordinator has been deallocated.
Nit: no need to early return here.

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/shipping_option_selection_coordinator.mm
(right):

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/shipping_option_selection_coordinator.mm:86: if
(!strongSelf)
Nit: no need to early return here.

[Moe, 2017-02-22 13:53:32]

On 2017/02/22 11:55:59, marq wrote:
> +mahmadi FYI
> 
>
https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
> File ios/chrome/browser/payments/payment_method_selection_coordinator.mm
> (right):
> 
>
https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
> ios/chrome/browser/payments/payment_method_selection_coordinator.mm:71: if
> (!strongSelf)
> Nit: No need to early return here.
> 
>
https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
> File ios/chrome/browser/payments/payment_request_coordinator.mm (right):
> 
>
https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
> ios/chrome/browser/payments/payment_request_coordinator.mm:143: -
> (instancetype)initWithBaseViewController:(UIViewController*)viewController {
> On 2017/02/21 17:22:35, sdefresne wrote:
> > maybe remove this method as you're just forwarding to the base class now
> 
> +1
> 
>
https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
> File ios/chrome/browser/payments/shipping_address_selection_coordinator.mm
> (right):
> 
>
https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
> ios/chrome/browser/payments/shipping_address_selection_coordinator.mm:87: //
> Early return if the coordinator has been deallocated.
> Nit: no need to early return here.
> 
>
https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
> File ios/chrome/browser/payments/shipping_option_selection_coordinator.mm
> (right):
> 
>
https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
> ios/chrome/browser/payments/shipping_option_selection_coordinator.mm:86: if
> (!strongSelf)
> Nit: no need to early return here.

Cool! I'll wait for this land before landing anything else. Thank you!

[stkhapugin, 2017-02-22 17:47:06]

Thanks, PTAL

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_method_selection_coordinator.mm
(right):

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_method_selection_coordinator.mm:71: if
(!strongSelf)
On 2017/02/22 11:55:58, marq wrote:
> Nit: No need to early return here.

Done.

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_coordinator.mm (right):

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_coordinator.mm:40:
base_view_controller_(base_view_controller){};
On 2017/02/21 17:22:35, sdefresne wrote:
> nit: remove trailing ;

Done.

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_coordinator.mm:143: -
(instancetype)initWithBaseViewController:(UIViewController*)viewController {
On 2017/02/22 11:55:58, marq wrote:
> On 2017/02/21 17:22:35, sdefresne wrote:
> > maybe remove this method as you're just forwarding to the base class now
> 
> +1

I originally tried doing this (see patchset 2). However, because it's marked as
NS_DESIGNATED_INITIALIZER here but not on superclass, clang issues an error for
not explicitly implementing it. Since I assume NS_DESIGNATED_INITIALIZER is
desired, but is not desired on superclass, I didn't want to change the API so
I've implemented an empty init here.

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/shipping_address_selection_coordinator.mm
(right):

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/shipping_address_selection_coordinator.mm:87: //
Early return if the coordinator has been deallocated.
On 2017/02/22 11:55:58, marq wrote:
> Nit: no need to early return here.

Done.

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/shipping_option_selection_coordinator.mm
(right):

https://codereview.chromium.org/2710493006/diff/40001/ios/chrome/browser/paym...
ios/chrome/browser/payments/shipping_option_selection_coordinator.mm:86: if
(!strongSelf)
On 2017/02/22 11:55:58, marq wrote:
> Nit: no need to early return here.

Done.

[sdefresne, 2017-02-22 17:50:55]

lgtm

[marq (ping after 24h), 2017-02-22 18:32:52]

lgtm

[stkhapugin, 2017-02-23 09:48:41]

Thanks!

[stkhapugin, 2017-02-23 09:48:46]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2017-02-23 09:48:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 11:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 11:06:04]

Failed to apply patch for ios/chrome/browser/payments/payment_request_util.mm:
While running git apply --index -p1;
  error: patch failed: ios/chrome/browser/payments/payment_request_util.mm:10
  error: ios/chrome/browser/payments/payment_request_util.mm: patch does not
apply

Patch:       ios/chrome/browser/payments/payment_request_util.mm
Index: ios/chrome/browser/payments/payment_request_util.mm
diff --git a/ios/chrome/browser/payments/payment_request_util.mm
b/ios/chrome/browser/payments/payment_request_util.mm
index
cdab28166d45bdf518ae7f43f6e3e6232b0cd3cc..989d9a15f5fdb4b627ca9d630458d30f7a8a5141
100644
--- a/ios/chrome/browser/payments/payment_request_util.mm
+++ b/ios/chrome/browser/payments/payment_request_util.mm
@@ -10,6 +10,10 @@
 #include "components/autofill/core/browser/field_types.h"
 #include "ios/chrome/browser/application_context.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 namespace payment_request_util {
 
 NSString* NameLabelFromAutofillProfile(autofill::AutofillProfile* profile) {

[stkhapugin, 2017-02-24 17:31:05]

The CQ bit was checked by stkhapugin@chromium.org

[stkhapugin, 2017-02-24 17:31:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2710493006/#ps100001
(title: "rebase?")

[commit-bot: I haz the power, 2017-02-24 17:31:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:04:38]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1487957465530220,
"parent_rev": "e6172c99f6d2ed7f1fe9a0ae26e3d836d6c931ac", "commit_rev":
"9c1d6844450a80766c882b007587f37e7b3e429d"}

[commit-bot: I haz the power, 2017-02-24 19:05:10]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/payments:payments to ARC.

Automatically generated ARCMigrate commit
Notable issues:
- Removed multiple delegate getter/setter/ivar combos with synthesize
- Fixed memory management in several blocks, for example:
 __weak ShippingOptionSelectionCoordinator* weakSelf = self;
  dispatch_after(
      dispatch_time(DISPATCH_TIME_NOW,
                    static_cast<int64_t>(0.2 * NSEC_PER_SEC)),
      dispatch_get_main_queue(), ^{
        ShippingOptionSelectionCoordinator* strongSelf = weakSelf;
        // Early return if the coordinator has been deallocated.
        if (!strongSelf)
          return;
        [_viewController setIsLoading:YES];
}

last line retains self through dereferenced ivar. Also further in the same
block:

        [_delegate shippingOptionSelectionCoordinator:self 
didSelectShippingOption:shippingOption];

direct reference to |self|


* In PaymentRequestViewController the following ivars are now strong: 
  PriceItem* _paymentSummaryItem;
  ShippingAddressItem* _selectedShippingAddressItem;
  CollectionViewTextItem* _selectedShippingOptionItem;
  PaymentMethodItem* _selectedPaymentMethodItem;

* For multiple view controllers with errorMessage property, it was changed from
assign to copy as this seems to reflect de-facto usage. 

BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/payments:payments to ARC.

Automatically generated ARCMigrate commit
Notable issues:
- Removed multiple delegate getter/setter/ivar combos with synthesize
- Fixed memory management in several blocks, for example:
 __weak ShippingOptionSelectionCoordinator* weakSelf = self;
  dispatch_after(
      dispatch_time(DISPATCH_TIME_NOW,
                    static_cast<int64_t>(0.2 * NSEC_PER_SEC)),
      dispatch_get_main_queue(), ^{
        ShippingOptionSelectionCoordinator* strongSelf = weakSelf;
        // Early return if the coordinator has been deallocated.
        if (!strongSelf)
          return;
        [_viewController setIsLoading:YES];
}

last line retains self through dereferenced ivar. Also further in the same
block:

        [_delegate shippingOptionSelectionCoordinator:self 
didSelectShippingOption:shippingOption];

direct reference to |self|


* In PaymentRequestViewController the following ivars are now strong: 
  PriceItem* _paymentSummaryItem;
  ShippingAddressItem* _selectedShippingAddressItem;
  CollectionViewTextItem* _selectedShippingOptionItem;
  PaymentMethodItem* _selectedPaymentMethodItem;

* For multiple view controllers with errorMessage property, it was changed from
assign to copy as this seems to reflect de-facto usage. 

BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2710493006
Cr-Commit-Position: refs/heads/master@{#452891}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c1d6844450a80766c882b007587...
==========

[commit-bot: I haz the power, 2017-02-24 19:05:12]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9c1d6844450a80766c882b007587...