Make WebMediaConstraitsPrivate ThreadSafeRefCounted

Make WebMediaConstraitsPrivate ThreadSafeRefCounted

WebMediaConstraitsPrivate had a non-thread-safe ref count, but accessed
from multiple threads. E.g. UserMediaClientImpl::SelectVideoDeviceSourceSettings()
makes a reference of WebMediaConstraitsPrivate via WebUserMediaRequest::videoConstraints(),
and passes it to a CategorizedWorkerPool, then the reference is dropped on the
worker thread without any protection.

BUG=688072
Review-Url: https://codereview.chromium.org/2710423002
Cr-Commit-Position: refs/heads/master@{#453505}
Committed: https://chromium.googlesource.com/chromium/src/+/0e0765474bc7bf13cbdf778d06bbc3be5783f11e

[tzik, 2017-02-24 07:58:45]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 07:58:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-02-24 08:01:19]

Description was changed from

==========
Make WebMediaConstraitsPrivate ThreadSafeRefCounted

WebMediaConstraitsPrivate had a non-thread-safe ref count, but accessed
from multiple threads. E.g.
UserMediaClientImpl::SelectVideoDeviceSourceSettings()
makes a reference of WebMediaConstraitsPrivate via
WebUserMediaRequest::videoConstraints(),
and passes it to a CategorizedWorkerPool.
==========

to

==========
Make WebMediaConstraitsPrivate ThreadSafeRefCounted

WebMediaConstraitsPrivate had a non-thread-safe ref count, but accessed
from multiple threads. E.g.
UserMediaClientImpl::SelectVideoDeviceSourceSettings()
makes a reference of WebMediaConstraitsPrivate via
WebUserMediaRequest::videoConstraints(),
and passes it to a CategorizedWorkerPool, then the reference is dropped on the
worker thread without any protection.

BUG=688072
==========

[tzik, 2017-02-24 08:03:36]

tzik@chromium.org changed reviewers:
+ qiangchen@chromium.org

[tzik, 2017-02-24 08:03:37]

PTAL

[commit-bot: I haz the power, 2017-02-24 08:28:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 08:28:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[qiangchen, 2017-02-24 16:57:28]

On 2017/02/24 08:03:37, tzik wrote:
> PTAL

Did you specify a wrong reviewer? I do not think I am an expert in
ThreadSafeRefCount.

[tzik, 2017-02-25 07:48:23]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 07:48:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-02-25 08:00:24]

On 2017/02/24 16:57:28, qiangchen wrote:
> On 2017/02/24 08:03:37, tzik wrote:
> > PTAL
> 
> Did you specify a wrong reviewer? I do not think I am an expert in
> ThreadSafeRefCount.

I'll request a platform owner later, but before that, I'd request media experts
to take a look to this to confirm the threading assumption here.

[commit-bot: I haz the power, 2017-02-25 09:39:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 09:39:09]

Dry run: This issue passed the CQ dry run.

[qiangchen, 2017-02-27 16:44:38]

lgtm

[tzik, 2017-02-28 00:57:19]

tzik@chromium.org changed reviewers:
+ haraken@chromium.org

[tzik, 2017-02-28 00:57:20]

Adding haraken for owner review. PTAL.

[haraken, 2017-02-28 02:27:43]

LGTM

[tzik, 2017-02-28 02:37:09]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-02-28 02:37:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 05:03:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488249429663810, "parent_rev":
"272eb7b955d8008142f9fd6615cea25161f684ac", "commit_rev":
"0e0765474bc7bf13cbdf778d06bbc3be5783f11e"}

[commit-bot: I haz the power, 2017-02-28 05:04:53]

Description was changed from

==========
Make WebMediaConstraitsPrivate ThreadSafeRefCounted

WebMediaConstraitsPrivate had a non-thread-safe ref count, but accessed
from multiple threads. E.g.
UserMediaClientImpl::SelectVideoDeviceSourceSettings()
makes a reference of WebMediaConstraitsPrivate via
WebUserMediaRequest::videoConstraints(),
and passes it to a CategorizedWorkerPool, then the reference is dropped on the
worker thread without any protection.

BUG=688072
==========

to

==========
Make WebMediaConstraitsPrivate ThreadSafeRefCounted

WebMediaConstraitsPrivate had a non-thread-safe ref count, but accessed
from multiple threads. E.g.
UserMediaClientImpl::SelectVideoDeviceSourceSettings()
makes a reference of WebMediaConstraitsPrivate via
WebUserMediaRequest::videoConstraints(),
and passes it to a CategorizedWorkerPool, then the reference is dropped on the
worker thread without any protection.

BUG=688072

Review-Url: https://codereview.chromium.org/2710423002
Cr-Commit-Position: refs/heads/master@{#453505}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e0765474bc7bf13cbdf778d06bb...
==========

[commit-bot: I haz the power, 2017-02-28 05:04:54]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e0765474bc7bf13cbdf778d06bb...