Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2710403002:
Use the loading task runner for mojo-loading (Closed)
DescriptionUse the loading task runner for mojo-loading
This CL sets the loading task runner for the resource loading data pipe
handle watcher. This CL doesn't set the task runner for URLLoaderClientImpl's
binding because it is not allowed for a channel associated interface.
BUG=603396
Review-Url: https://codereview.chromium.org/2710403002
Cr-Original-Commit-Position: refs/heads/master@{#452778}
Committed: https://chromium.googlesource.com/chromium/src/+/63e321a30306e18812ad0cdaa6be57964497ac01
Review-Url: https://codereview.chromium.org/2710403002
Cr-Commit-Position: refs/heads/master@{#452966}
Committed: https://chromium.googlesource.com/chromium/src/+/a2adc9e7c94a24c344395a8be00ff2c5f1b6f84c
Patch Set 1 #Patch Set 2 : fix #
Messages
Total messages: 31 (20 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
yhirano@chromium.org changed reviewers: + tzik@chromium.org
lgtm
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487922231260710, "parent_rev":
"cf0ab238b4f5a91ecfa79abe30afabd8f94da6bd", "commit_rev":
"63e321a30306e18812ad0cdaa6be57964497ac01"}
Message was sent while issue was closed.
Description was changed from ========== Use the loading task runner for mojo-loading BUG=603396 ========== to ========== Use the loading task runner for mojo-loading BUG=603396 Review-Url: https://codereview.chromium.org/2710403002 Cr-Commit-Position: refs/heads/master@{#452778} Committed: https://chromium.googlesource.com/chromium/src/+/63e321a30306e18812ad0cdaa6be... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/63e321a30306e18812ad0cdaa6be...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2717523004/ by yhirano@chromium.org. The reason for reverting is: Breaking virtual/mojo-loading layout tests..
Message was sent while issue was closed.
Description was changed from ========== Use the loading task runner for mojo-loading BUG=603396 Review-Url: https://codereview.chromium.org/2710403002 Cr-Commit-Position: refs/heads/master@{#452778} Committed: https://chromium.googlesource.com/chromium/src/+/63e321a30306e18812ad0cdaa6be... ========== to ========== Use the loading task runner for mojo-loading BUG=603396 Review-Url: https://codereview.chromium.org/2710403002 Cr-Commit-Position: refs/heads/master@{#452778} Committed: https://chromium.googlesource.com/chromium/src/+/63e321a30306e18812ad0cdaa6be... ==========
reopening...
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Use the loading task runner for mojo-loading BUG=603396 Review-Url: https://codereview.chromium.org/2710403002 Cr-Commit-Position: refs/heads/master@{#452778} Committed: https://chromium.googlesource.com/chromium/src/+/63e321a30306e18812ad0cdaa6be... ========== to ========== Use the loading task runner for mojo-loading This CL sets the loading task runner for the resource loading data pipe handle watcher. This CL doesn't set the task runner for URLLoaderClientImpl's binding because it is not allowed for a channel associated interface. BUG=603396 Review-Url: https://codereview.chromium.org/2710403002 Cr-Commit-Position: refs/heads/master@{#452778} Committed: https://chromium.googlesource.com/chromium/src/+/63e321a30306e18812ad0cdaa6be... ==========
Relanding with a modification.
The CQ bit was unchecked by yhirano@chromium.org
The CQ bit was checked by yhirano@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tzik@chromium.org Link to the patchset: https://codereview.chromium.org/2710403002/#ps20001 (title: "fix")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by yhirano@chromium.org
The CQ bit was unchecked by yhirano@chromium.org
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487975316891820,
"parent_rev": "e54bc779bf060c6704d4a581ee7137bb268c6b7c", "commit_rev":
"a2adc9e7c94a24c344395a8be00ff2c5f1b6f84c"}
Message was sent while issue was closed.
Description was changed from ========== Use the loading task runner for mojo-loading This CL sets the loading task runner for the resource loading data pipe handle watcher. This CL doesn't set the task runner for URLLoaderClientImpl's binding because it is not allowed for a channel associated interface. BUG=603396 Review-Url: https://codereview.chromium.org/2710403002 Cr-Commit-Position: refs/heads/master@{#452778} Committed: https://chromium.googlesource.com/chromium/src/+/63e321a30306e18812ad0cdaa6be... ========== to ========== Use the loading task runner for mojo-loading This CL sets the loading task runner for the resource loading data pipe handle watcher. This CL doesn't set the task runner for URLLoaderClientImpl's binding because it is not allowed for a channel associated interface. BUG=603396 Review-Url: https://codereview.chromium.org/2710403002 Cr-Original-Commit-Position: refs/heads/master@{#452778} Committed: https://chromium.googlesource.com/chromium/src/+/63e321a30306e18812ad0cdaa6be... Review-Url: https://codereview.chromium.org/2710403002 Cr-Commit-Position: refs/heads/master@{#452966} Committed: https://chromium.googlesource.com/chromium/src/+/a2adc9e7c94a24c344395a8be00f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/a2adc9e7c94a24c344395a8be00f... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
