Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 2710323004: Revert "Refined types for most HtmlElement factory constructors" (Closed)

Created:
3 years, 9 months ago by sra1
Modified:
3 years, 9 months ago
Reviewers:
Alan Knight
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Refined types for most HtmlElement factory constructors" Need to fix ShadowElement TBR=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/963df1e3e1a3bac0013d191d2b02898bbebefa9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -229 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 49 chunks +86 lines, -91 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +36 lines, -41 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/css_code_generator.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 chunk +11 lines, -9 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +0 lines, -33 lines 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +34 lines, -39 lines 0 comments Download
M tools/dom/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sra1
3 years, 9 months ago (2017-02-24 22:15:50 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
963df1e3e1a3bac0013d191d2b02898bbebefa9d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698