tools/dom/scripts/systemnative.py - Issue 2710323004: Revert "Refined types for most HtmlElement factory constructors"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/systemnative.py

Issue 2710323004: Revert "Refined types for most HtmlElement factory constructors" (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/systemnative.py

diff --git a/tools/dom/scripts/systemnative.py b/tools/dom/scripts/systemnative.py

index 1df7f8cf952559d865f0ba709e3cc761d1e353e3..659d24cbe815a55cd0277597d817b5657121a197 100644

--- a/tools/dom/scripts/systemnative.py

+++ b/tools/dom/scripts/systemnative.py

@@ -308,13 +308,6 @@ class DartiumBackend(HtmlDartGenerator):

def IsConstructorArgumentOptional(self, argument):

return IsOptional(argument)

- def MakeFactoryCall(self, factory, method, arguments, constructor_info):

- return emitter.Format(

- '$FACTORY.$METHOD($ARGUMENTS)',

- FACTORY=factory,

- METHOD=method,

- ARGUMENTS=arguments)

def EmitStaticFactoryOverload(self, constructor_info, name, arguments):

constructor_callback_cpp_name = name + 'constructorCallback'

self._EmitConstructorInfrastructure(