Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2710323003: 🏠 Close the bottom sheet when opening link in incognito (Closed)
Patch Set: Properly make ContentSuggestionsActivity compile Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index fe031a1c1322ddda60da890041c5a3c86f0ab177..e09ce1c2791c2b854f5317c2d9e0b428b6f8d1eb 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -47,7 +47,6 @@
import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.IntentHandler.TabOpenType;
import org.chromium.chrome.browser.NativePage;
-import org.chromium.chrome.browser.NativePageHost;
import org.chromium.chrome.browser.SwipeRefreshHandler;
import org.chromium.chrome.browser.TabState;
import org.chromium.chrome.browser.TabState.WebContentsState;
@@ -128,8 +127,8 @@
* their own native pointer reference, but Tab#destroy() will handle deleting the native
* object.
*/
-public class Tab implements ViewGroup.OnHierarchyChangeListener,
- View.OnSystemUiVisibilityChangeListener, NativePageHost {
+public class Tab
+ implements ViewGroup.OnHierarchyChangeListener, View.OnSystemUiVisibilityChangeListener {
public static final int INVALID_TAB_ID = -1;
/** Return value from {@link #getBookmarkId()} if this tab is not bookmarked. */
@@ -638,7 +637,6 @@ protected void requestRestoreLoad() {
* @return FULL_PRERENDERED_PAGE_LOAD or PARTIAL_PRERENDERED_PAGE_LOAD if the page has been
* prerendered. DEFAULT_PAGE_LOAD if it had not.
*/
- @Override
public int loadUrl(LoadUrlParams params) {
try {
TraceEvent.begin("Tab.loadUrl");
@@ -1009,7 +1007,6 @@ public int getId() {
return mId;
}
- @Override
public boolean isIncognito() {
return mIncognito;
}
@@ -2127,16 +2124,10 @@ public boolean isBeingRestored() {
/**
* @return The id of the tab that caused this tab to be opened.
*/
- @Override
public int getParentId() {
return mParentId;
}
- @Override
- public Tab getActiveTab() {
- return this;
- }
-
/**
* @return Whether the tab should be grouped with its parent tab (true by default).
*/

Powered by Google App Engine
This is Rietveld 408576698