Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4670)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java

Issue 2710323003: 🏠 Close the bottom sheet when opening link in incognito (Closed)
Patch Set: Properly make ContentSuggestionsActivity compile Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
index 2fff2de42b95122aa93ebc1697820352c911bfe5..443bb882290453338cf9024ef707c4a07be493b6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
@@ -72,7 +72,7 @@ public void navigateToBookmarks() {
@Override
public void navigateToRecentTabs() {
RecordUserAction.record("MobileNTPSwitchToOpenTabs");
- mHost.loadUrl(new LoadUrlParams(UrlConstants.RECENT_TABS_URL));
+ mHost.loadUrl(new LoadUrlParams(UrlConstants.RECENT_TABS_URL), /* incognito = */ false);
}
@Override
@@ -147,13 +147,13 @@ public void openSnippet(int windowOpenDisposition, SnippetArticle article) {
public void openUrl(int windowOpenDisposition, LoadUrlParams loadUrlParams) {
switch (windowOpenDisposition) {
case WindowOpenDisposition.CURRENT_TAB:
- mHost.loadUrl(loadUrlParams);
+ mHost.loadUrl(loadUrlParams, false);
break;
case WindowOpenDisposition.NEW_BACKGROUND_TAB:
- openUrlInNewTab(loadUrlParams, false);
+ openUrlInNewTab(loadUrlParams);
break;
case WindowOpenDisposition.OFF_THE_RECORD:
- openUrlInNewTab(loadUrlParams, true);
+ mHost.loadUrl(loadUrlParams, true);
break;
case WindowOpenDisposition.NEW_WINDOW:
openUrlInNewWindow(loadUrlParams);
@@ -180,9 +180,9 @@ private void openUrlInNewWindow(LoadUrlParams loadUrlParams) {
tabDelegate.createTabInOtherWindow(loadUrlParams, mActivity, mHost.getParentId());
}
- private void openUrlInNewTab(LoadUrlParams loadUrlParams, boolean incognito) {
+ private void openUrlInNewTab(LoadUrlParams loadUrlParams) {
mTabModelSelector.openNewTab(loadUrlParams, TabLaunchType.FROM_LONGPRESS_BACKGROUND,
- mHost.getActiveTab(), incognito);
+ mHost.getActiveTab(), /* incognito = */ false);
}
private void saveUrlForOffline(String url) {

Powered by Google App Engine
This is Rietveld 408576698