rework analyzer_cli to use ContextBuilder getAnalysisOptions

rework analyzer_cli to use ContextBuilder getAnalysisOptions

This is a follow on to https://codereview.chromium.org/2716693003
that refactors analyzer_cli to use ContextBuilder.
As a result, dartanalyzer now correctly finds the default
flutter analysis options when the project references package:flutter
but does not contain an analysis options file.

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/abee739921f4770fa6b69c5256803adc4fae4d08

[danrubel, 2017-02-23 21:20:35]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2017-02-23 21:29:23]

lgtm, thanks!

https://codereview.chromium.org/2710313002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/2710313002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:751: options:
options.contextBuilderOptions)
Might be good to create a ContextBuilder in one place and make it available
everywhere (such as a field) to make it easier to replace more code with calls
to ContextBuilder. (Maybe as a follow-on CL.)

https://codereview.chromium.org/2710313002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:768: //contextOptions.implicitDynamic =
options.implicitDynamic;
Did you intend to remove these?

[danrubel, 2017-02-23 21:51:20]

https://codereview.chromium.org/2710313002/diff/1/pkg/analyzer_cli/lib/src/dr...
File pkg/analyzer_cli/lib/src/driver.dart (right):

https://codereview.chromium.org/2710313002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:751: options:
options.contextBuilderOptions)
On 2017/02/23 21:29:23, Brian Wilkerson wrote:
> Might be good to create a ContextBuilder in one place and make it available
> everywhere (such as a field) to make it easier to replace more code with calls
> to ContextBuilder. (Maybe as a follow-on CL.)

Good point. I'll do that when we start using ContextBuilder to build the context
as well as get the analysis options.

https://codereview.chromium.org/2710313002/diff/1/pkg/analyzer_cli/lib/src/dr...
pkg/analyzer_cli/lib/src/driver.dart:768: //contextOptions.implicitDynamic =
options.implicitDynamic;
On 2017/02/23 21:29:22, Brian Wilkerson wrote:
> Did you intend to remove these?

Yeah. Forgot to do so. Now removed.

[danrubel, 2017-02-23 21:52:34]

Description was changed from

==========
rework analyzer_cli to use ContextBuilder getAnalysisOptions

This is a follow on to https://codereview.chromium.org/2716693003
that refactors analyzer_cli to use ContextBuilder.
As a result, dartanalyzer now correctly finds the default
flutter analysis options when the project references package:flutter
but does not contain an analysis options file.
==========

to

==========
rework analyzer_cli to use ContextBuilder getAnalysisOptions

This is a follow on to https://codereview.chromium.org/2716693003
that refactors analyzer_cli to use ContextBuilder.
As a result, dartanalyzer now correctly finds the default
flutter analysis options when the project references package:flutter
but does not contain an analysis options file.

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/abee739921f4770fa6b69c5256803adc4fae4d08
==========

[danrubel, 2017-02-23 21:52:35]

Committed patchset #3 (id:40001) manually as
abee739921f4770fa6b69c5256803adc4fae4d08 (presubmit successful).