Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2716693003: enhance ContextBuilder getAnalysisOptions to handle lints (Closed)

Created:
3 years, 10 months ago by danrubel
Modified:
3 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

enhance ContextBuilder getAnalysisOptions to handle lints This updates ContextBuilder to process the --lints command line option: * --[no-]lints enables (or disables) lints * if --lints but no lints specified in analysis options then the default set of lints is used * if --no-lints then lints are turned off regardless of what is specified in the analysis options * if neither --lints nor --no-lints are specified then lints are turned on iff analysis options specifies lints My next step is to update analyzer_cli to use ContextBuilder getAnalysisOptions R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/289888cd0edbf225d4d9d09e583d884f2e0cbbb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -22 lines) Patch
M pkg/analyzer/lib/src/command_line/arguments.dart View 3 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/command_line/arguments_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 7 chunks +157 lines, -18 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
3 years, 10 months ago (2017-02-23 21:07:05 UTC) #2
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-23 21:21:47 UTC) #3
danrubel
3 years, 10 months ago (2017-02-23 21:23:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
289888cd0edbf225d4d9d09e583d884f2e0cbbb3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698