Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2710303002: [turbofan] TurboFan doesn't use String allocation pretenuring feedback. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] TurboFan doesn't use String allocation pretenuring feedback. We can make Heap::UpdateAllocationSite cheaper for TurboFan, because there's no need to check for allocation mementos on Strings in case of the TurboFan pipeline. R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2710303002 Cr-Commit-Position: refs/heads/master@{#43407} Committed: https://chromium.googlesource.com/v8/v8/+/208014abea8fff770b149cd52d10a4acbfa745dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-23 18:47:17 UTC) #1
mvstanton
lgtm
3 years, 10 months ago (2017-02-24 08:31:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710303002/1
3 years, 10 months ago (2017-02-24 08:37:04 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 09:19:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/208014abea8fff770b149cd52d10a4acbfa...

Powered by Google App Engine
This is Rietveld 408576698