Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2710273002: Split DisabledForEphemeralDataUsers tests into ChromeArcUtilTest. (Closed)

Created:
3 years, 10 months ago by hidehiko
Modified:
3 years, 10 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, khmel
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split DisabledForEphemeralDataUsers tests into ChromeArcUtilTest. The test case is for IsArcAllowedForProfile(). This CL splits it into several test cases, and test each. BUG=657687 BUG=b/31079732 TEST=Ran trybots. Review-Url: https://codereview.chromium.org/2710273002 Cr-Commit-Position: refs/heads/master@{#452579} Committed: https://chromium.googlesource.com/chromium/src/+/74be432e0e54671c12f63a8a6fd30cd49687e8c2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -47 lines) Patch
M chrome/browser/chromeos/arc/arc_session_manager_unittest.cc View 1 chunk +0 lines, -45 lines 1 comment Download
M chrome/browser/chromeos/arc/arc_util_unittest.cc View 5 chunks +29 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
hidehiko
PTAL. This is also preparation to move ArcSessionManager to components/arc.
3 years, 10 months ago (2017-02-23 19:04:49 UTC) #6
hidehiko
https://codereview.chromium.org/2710273002/diff/1/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc File chrome/browser/chromeos/arc/arc_session_manager_unittest.cc (left): https://codereview.chromium.org/2710273002/diff/1/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc#oldcode277 chrome/browser/chromeos/arc/arc_session_manager_unittest.cc:277: const AccountId not_in_list_account_id( Note: this case is redundant, because ...
3 years, 10 months ago (2017-02-23 19:05:54 UTC) #7
Luis Héctor Chávez
ha! this made the code nicer :) lgtm
3 years, 10 months ago (2017-02-23 19:11:11 UTC) #8
hidehiko
Wow, thank you very much for very quick review!
3 years, 10 months ago (2017-02-23 19:13:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710273002/1
3 years, 10 months ago (2017-02-23 19:14:35 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 19:21:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/74be432e0e54671c12f63a8a6fd3...

Powered by Google App Engine
This is Rietveld 408576698