Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2710263003: Replace usage of FrameLoaderClient.h with LocalFrameClient.h for files in: (Closed)

Created:
3 years, 10 months ago by slangley
Modified:
3 years, 10 months ago
Reviewers:
haraken, joelhockey
CC:
blink-frame-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace usage of FrameLoaderClient.h with LocalFrameClient.h for files in: - bindings/v8 - bindings *** This is just a rename CL - There are no logic changes *** BUG=694773 Review-Url: https://codereview.chromium.org/2710263003 Cr-Commit-Position: refs/heads/master@{#453108} Committed: https://chromium.googlesource.com/chromium/src/+/e339b2c841d7ed2c32ba00ba8ba2eec27c675ce9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 2 chunks +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (4 generated)
slangley
3 years, 10 months ago (2017-02-24 06:05:01 UTC) #2
slangley
3 years, 10 months ago (2017-02-24 06:07:08 UTC) #3
joelhockey
lgtm
3 years, 10 months ago (2017-02-24 06:15:54 UTC) #4
haraken
LGTM
3 years, 10 months ago (2017-02-24 07:05:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710263003/1
3 years, 10 months ago (2017-02-25 22:19:00 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 23:53:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e339b2c841d7ed2c32ba00ba8ba2...

Powered by Google App Engine
This is Rietveld 408576698