Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2710223002: Rename GpuMemoryBufferImplOzoneNativePixmap to GpuMemoryBufferImplNativePixmap (Closed)

Created:
3 years, 10 months ago by Julien Isorce
Modified:
3 years, 8 months ago
Reviewers:
reveman, piman
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename GpuMemoryBufferImplOzoneNativePixmap to GpuMemoryBufferImplNativePixmap And rename files gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.{cc,h} => gpu/ipc/client/gpu_memory_buffer_impl_native_pixmap.{cc,h} Turn on GpuMemoryBufferImplNativePixmap on OS_LINUX instead of only USE_ZONE. This a pre-step to enable glCreateImageCHROMIUM with linux dma buf on linux. BUG=584248 R=reveman@chromium.org TBR=kbr@chromium.org, piman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2710223002 Cr-Commit-Position: refs/heads/master@{#464342} Committed: https://chromium.googlesource.com/chromium/src/+/fdc307c24e827fe545c6dfd0250a0958d828d7c7

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix an include #

Patch Set 4 : Move one enablement from next CL to this CL to fix a unit test #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -263 lines) Patch
M components/exo/display.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -2 lines 0 comments Download
M gpu/ipc/client/BUILD.gn View 1 2 3 4 5 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/ipc/client/gpu_memory_buffer_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_native_pixmap.h View 1 2 3 4 4 chunks +8 lines, -9 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_native_pixmap.cc View 1 2 3 4 4 chunks +27 lines, -16 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_native_pixmap_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.h View 1 2 3 4 1 chunk +0 lines, -69 lines 0 comments Download
D gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 1 2 3 4 1 chunk +0 lines, -139 lines 0 comments Download
D gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 40 (33 generated)
Julien Isorce
Hi David, please take a look. Thx.
3 years, 9 months ago (2017-03-23 20:12:54 UTC) #17
Julien Isorce
On 2017/03/23 20:12:54, Julien Isorce wrote: > Hi David, please take a look. Thx. Gentle ...
3 years, 8 months ago (2017-03-28 15:28:34 UTC) #18
reveman
lgtm
3 years, 8 months ago (2017-04-12 18:07:09 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710223002/120001
3 years, 8 months ago (2017-04-13 08:25:35 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/410219)
3 years, 8 months ago (2017-04-13 08:35:41 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710223002/120001
3 years, 8 months ago (2017-04-13 08:43:21 UTC) #37
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 08:49:59 UTC) #40
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/fdc307c24e827fe545c6dfd0250a...

Powered by Google App Engine
This is Rietveld 408576698