[NGLayout] Collapse margins before processing LayoutInline.

[NGLayout] Collapse margins before processing LayoutInline.

BUG=635619
TEST=NGBlockLayoutAlgorithmTest::CollapsingMarginsWithText

Review-Url: https://codereview.chromium.org/2710213007
Cr-Commit-Position: refs/heads/master@{#453301}
Committed: https://chromium.googlesource.com/chromium/src/+/914fc639576ee35d6ff261a02adc9ecf852b6a4e

[Gleb Lanbin, 2017-02-25 00:14:40]

glebl@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[Gleb Lanbin, 2017-02-25 00:16:19]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 00:16:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2017-02-25 00:59:17]

https://codereview.chromium.org/2710213007/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2710213007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:784:
UpdateFragmentBfcOffset(curr_bfc_offset_, builder_.get());
we'll need to position the floats here as well right?

[Gleb Lanbin, 2017-02-25 01:14:55]

https://codereview.chromium.org/2710213007/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc
(right):

https://codereview.chromium.org/2710213007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc:784:
UpdateFragmentBfcOffset(curr_bfc_offset_, builder_.get());
On 2017/02/25 00:59:17, ikilpatrick wrote:
> we'll need to position the floats here as well right?

yes

[Gleb Lanbin, 2017-02-25 01:15:06]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-25 01:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 02:39:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 02:40:00]

Dry run: This issue passed the CQ dry run.

[ikilpatrick, 2017-02-27 17:25:35]

lgtm

[Gleb Lanbin, 2017-02-27 17:26:00]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:26:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 17:39:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 17:39:28]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Gleb Lanbin, 2017-02-27 17:51:45]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2017-02-27 17:51:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2710213007/#ps40001
(title: "git rebase-update")

[commit-bot: I haz the power, 2017-02-27 17:52:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 19:42:14]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488217905575630,
"parent_rev": "d06419a9457679d7daf3e513c3f72431233ca708", "commit_rev":
"914fc639576ee35d6ff261a02adc9ecf852b6a4e"}

[commit-bot: I haz the power, 2017-02-27 19:43:35]

Description was changed from

==========
[NGLayout] Collapse margins before processing LayoutInline.

BUG=635619
TEST=NGBlockLayoutAlgorithmTest::CollapsingMarginsWithText
==========

to

==========
[NGLayout] Collapse margins before processing LayoutInline.

BUG=635619
TEST=NGBlockLayoutAlgorithmTest::CollapsingMarginsWithText

Review-Url: https://codereview.chromium.org/2710213007
Cr-Commit-Position: refs/heads/master@{#453301}
Committed:
https://chromium.googlesource.com/chromium/src/+/914fc639576ee35d6ff261a02adc...
==========

[commit-bot: I haz the power, 2017-02-27 19:43:37]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/914fc639576ee35d6ff261a02adc...