[DevTools] show inlined shortcuts for go to location

[DevTools] show inlined shortcuts for go to location

Under experiment.

BUG=chromium:695236
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2710203003
Cr-Commit-Position: refs/heads/master@{#453351}
Committed: https://chromium.googlesource.com/chromium/src/+/36db3e33fd42adbff2cb0026eba1c031cdb0fc48

[kozy, 2017-02-24 03:12:45]

Screenshot: http://imgur.com/a/Jx42I
I think we can polish it later and it's good enough to start an experiment.

Dmitry, please take a look.

[dgozman, 2017-02-24 19:49:42]

lgtm

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:101:
Runtime.experiments.register('continueToFirstInvocation', 'Continue to first
invocation', true);
Remove this one please.

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:113:
Runtime.experiments.register('inlineContinueToLocation', 'Show inline shortcuts
for continue to location');
- make it hidden;
- "Continue to location markers"

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:616:
this.textEditor.operation(() => bookmarks.map(bookmark => bookmark.clear()));
This function is already run as operation. Just call bookmark.clear() directly?

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:621:
continue;
So, the current one will appear/disappear anyway?

[kozy, 2017-02-24 20:04:46]

all done.
I'll land this one as soon as V8 side is ready.

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/main/Main.js (right):

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:101:
Runtime.experiments.register('continueToFirstInvocation', 'Continue to first
invocation', true);
On 2017/02/24 19:49:42, dgozman wrote:
> Remove this one please.

Done.

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/main/Main.js:113:
Runtime.experiments.register('inlineContinueToLocation', 'Show inline shortcuts
for continue to location');
On 2017/02/24 19:49:42, dgozman wrote:
> - make it hidden;
> - "Continue to location markers"

Done.

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js
(right):

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:616:
this.textEditor.operation(() => bookmarks.map(bookmark => bookmark.clear()));
On 2017/02/24 19:49:42, dgozman wrote:
> This function is already run as operation. Just call bookmark.clear()
directly?

Done.

https://codereview.chromium.org/2710203003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js:621:
continue;
On 2017/02/24 19:49:42, dgozman wrote:
> So, the current one will appear/disappear anyway?

Yes..
I removed this logic because in case of more then one dot in line, e.g.:
promise.then().then().then() 
it forces all other dots jumps - it doesn't look good.

[kozy, 2017-02-24 20:04:55]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 20:05:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 22:45:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 22:45:26]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-02-27 20:08:53]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 20:09:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 21:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 21:32:32]

Dry run: This issue passed the CQ dry run.

[kozy, 2017-02-27 21:55:01]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2017-02-27 21:55:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2710203003/#ps40001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-02-27 21:55:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 22:01:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488232501189000,
"parent_rev": "632494935842a648384318810c1a8ea67b389753", "commit_rev":
"36db3e33fd42adbff2cb0026eba1c031cdb0fc48"}

[commit-bot: I haz the power, 2017-02-27 22:02:10]

Description was changed from

==========
[DevTools] show inlined shortcuts for go to location

Under experiment.

BUG=chromium:695236
R=dgozman@chromium.org
==========

to

==========
[DevTools] show inlined shortcuts for go to location

Under experiment.

BUG=chromium:695236
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2710203003
Cr-Commit-Position: refs/heads/master@{#453351}
Committed:
https://chromium.googlesource.com/chromium/src/+/36db3e33fd42adbff2cb0026eba1...
==========

[commit-bot: I haz the power, 2017-02-27 22:02:12]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/36db3e33fd42adbff2cb0026eba1...