Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2710193007:
Implement the LoFi Integration Test with ChromeDriver (Closed)
DescriptionImplement the LoFi Integration Test with ChromeDriver
BUG=680566
Review-Url: https://codereview.chromium.org/2710193007
Cr-Commit-Position: refs/heads/master@{#452960}
Committed: https://chromium.googlesource.com/chromium/src/+/92ff6b808e69994629026ecb9d15ac48fd8bcd4d
Patch Set 1 #
Total comments: 2
Patch Set 2 : use assertIn #Messages
Total messages: 18 (9 generated)
megjablon@chromium.org changed reviewers: + sclittle@chromium.org
PTAL, thanks!
robertogden@chromium.org changed reviewers: + robertogden@chromium.org
lgmt % nit https://codereview.chromium.org/2710193007/diff/1/tools/chrome_proxy/webdrive... File tools/chrome_proxy/webdriver/lofi.py (right): https://codereview.chromium.org/2710193007/diff/1/tools/chrome_proxy/webdrive... tools/chrome_proxy/webdriver/lofi.py:10: class Bypass(IntegrationTest): Maybe LoFi or something besides Bypass
https://codereview.chromium.org/2710193007/diff/1/tools/chrome_proxy/webdrive... File tools/chrome_proxy/webdriver/lofi.py (right): https://codereview.chromium.org/2710193007/diff/1/tools/chrome_proxy/webdrive... tools/chrome_proxy/webdriver/lofi.py:10: class Bypass(IntegrationTest): On 2017/02/23 21:56:24, Robert Ogden wrote: > Maybe LoFi or something besides Bypass Just caught that when working on other tests and then saw your comment :) Whoops! Fixed.
lgtm (again) since I can't spell
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by megjablon@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robertogden@chromium.org Link to the patchset: https://codereview.chromium.org/2710193007/#ps40001 (title: "use assertIn")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
lgtm lgtm
The CQ bit was checked by megjablon@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487974845513390,
"parent_rev": "a19cc1934ae522d7b4a78fa466ca364ab10c83b8", "commit_rev":
"92ff6b808e69994629026ecb9d15ac48fd8bcd4d"}
Message was sent while issue was closed.
Description was changed from ========== Implement the LoFi Integration Test with ChromeDriver BUG=680566 ========== to ========== Implement the LoFi Integration Test with ChromeDriver BUG=680566 Review-Url: https://codereview.chromium.org/2710193007 Cr-Commit-Position: refs/heads/master@{#452960} Committed: https://chromium.googlesource.com/chromium/src/+/92ff6b808e69994629026ecb9d15... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/92ff6b808e69994629026ecb9d15... |
