Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: pkg/analysis_server/test/integration/integration_tests.dart

Issue 2710193002: Update the analysis server integration tests to always run on the analysis driver. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/integration/integration_tests.dart
diff --git a/pkg/analysis_server/test/integration/integration_tests.dart b/pkg/analysis_server/test/integration/integration_tests.dart
index ebd6ff8d501d678acb37f3ccd56adf6208f1077f..2f3b866a985409f0b90228f3e2def7ad13bef342 100644
--- a/pkg/analysis_server/test/integration/integration_tests.dart
+++ b/pkg/analysis_server/test/integration/integration_tests.dart
@@ -125,7 +125,8 @@ abstract class AbstractAnalysisServerIntegrationTest
*/
bool _subscribedToServerStatus = false;
- List<AnalysisError> getErrors(String pathname) => currentAnalysisErrors[pathname];
+ List<AnalysisError> getErrors(String pathname) =>
+ currentAnalysisErrors[pathname];
AbstractAnalysisServerIntegrationTest() {
initializeInttestMixin();
@@ -156,11 +157,6 @@ abstract class AbstractAnalysisServerIntegrationTest
}
/**
- * Return `true` if the new analysis driver should be used by these tests.
- */
- bool get enableNewAnalysisDriver => false;
-
- /**
* Print out any messages exchanged with the server. If some messages have
* already been exchanged with the server, they are printed out immediately.
*/
@@ -250,7 +246,6 @@ abstract class AbstractAnalysisServerIntegrationTest
server.start(
checked: checked,
diagnosticPort: diagnosticPort,
- enableNewAnalysisDriver: enableNewAnalysisDriver,
servicesPort: servicesPort);
/**
@@ -659,7 +654,6 @@ class Server {
Future start(
{bool checked: true,
int diagnosticPort,
- bool enableNewAnalysisDriver: false,
bool noErrorNotification: false,
bool profileServer: false,
String sdkPath,
@@ -713,9 +707,6 @@ class Server {
if (useAnalysisHighlight2) {
arguments.add('--useAnalysisHighlight2');
}
- if (!enableNewAnalysisDriver) {
- arguments.add('--disable-new-analysis-driver');
- }
if (noErrorNotification) {
arguments.add('--no-error-notification');
}

Powered by Google App Engine
This is Rietveld 408576698