Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2710153004: cc: Fix up code to work with concrete cc paint types (Closed)

Created:
3 years, 10 months ago by enne (OOO)
Modified:
3 years, 10 months ago
Reviewers:
danakj, vmpstr
CC:
cc-bugs_chromium.org, chromium-reviews, danakj, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix up code to work with concrete cc paint types This is split off from my wip https://codereview.chromium.org/2690583002 patch and includes all the places where I ended up changing cc to compile properly when using real types. BUG=671433 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2710153004 Cr-Commit-Position: refs/heads/master@{#453000} Committed: https://chromium.googlesource.com/chromium/src/+/5a963036e01f36fef69a05accdf2725e631d0ed0

Patch Set 1 #

Patch Set 2 : just cc #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -116 lines) Patch
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/renderer_pixeltest.cc View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M cc/playback/discardable_image_map_unittest.cc View 8 chunks +21 lines, -21 lines 0 comments Download
M cc/playback/display_item_list_unittest.cc View 14 chunks +54 lines, -53 lines 0 comments Download
M cc/playback/drawing_display_item.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M cc/playback/recording_source_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M cc/raster/gpu_raster_buffer_provider.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/fake_raster_source.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/test/fake_raster_source.cc View 2 chunks +2 lines, -1 line 0 comments Download
M cc/test/fake_scrollbar.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M cc/test/skia_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_pixeltest_filters.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (15 generated)
enne (OOO)
3 years, 10 months ago (2017-02-23 19:27:20 UTC) #6
enne (OOO)
3 years, 10 months ago (2017-02-24 19:25:16 UTC) #11
vmpstr
lgtm
3 years, 10 months ago (2017-02-24 22:14:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710153004/40001
3 years, 10 months ago (2017-02-24 22:16:49 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 23:41:43 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5a963036e01f36fef69a05accdf2...

Powered by Google App Engine
This is Rietveld 408576698