Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2710123002: [Mac] Flip toolbar button images in RTL (Closed)

Created:
3 years, 10 months ago by lgrey
Modified:
3 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jshin+watch_chromium.org, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Flip toolbar button images in RTL Just wastefully flipping everything instead of trying to get clever here (but n = 5, so...) BUG=693783 Review-Url: https://codereview.chromium.org/2710123002 Cr-Commit-Position: refs/heads/master@{#452292} Committed: https://chromium.googlesource.com/chromium/src/+/1f70ddc9356fa9b1e2ec5f64c92ee09ba740bc41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/l10n_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/l10n_util.mm View 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
lgrey
PTAL :)
3 years, 10 months ago (2017-02-22 21:57:54 UTC) #2
Avi (use Gerrit)
lgtm Better, thank you.
3 years, 10 months ago (2017-02-22 22:35:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710123002/1
3 years, 10 months ago (2017-02-22 23:28:42 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 00:10:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f70ddc9356fa9b1e2ec5f64c92e...

Powered by Google App Engine
This is Rietveld 408576698