cocoa: darken toolbar buttons in Increase Contrast mode

cocoa: darken toolbar buttons in Increase Contrast mode

BUG=687227
Review-Url: https://codereview.chromium.org/2710103003
Cr-Commit-Position: refs/heads/master@{#452544}
Committed: https://chromium.googlesource.com/chromium/src/+/f74bb3ef462cccad2c007d934c21b730c8d9bf08

[Elly Fong-Jones, 2017-02-22 21:09:55]

Description was changed from

==========
cocoa: darken toolbar buttons in Increase Contrast mode

BUG=687227
==========

to

==========
cocoa: darken toolbar buttons in Increase Contrast mode

BUG=687227
==========

[Elly Fong-Jones, 2017-02-22 21:09:55]

ellyjones@chromium.org changed reviewers:
+ mark@chromium.org

[Elly Fong-Jones, 2017-02-22 21:10:05]

mark: ptal? :)

[Mark Mentovai, 2017-02-23 01:54:17]

LGTM

https://codereview.chromium.org/2710103003/diff/1/chrome/browser/ui/cocoa/too...
File chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm (right):

https://codereview.chromium.org/2710103003/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/app_toolbar_button.mm:58: : provider &&
provider->ShouldIncreaseContrast()
I suggest but don’t require (parentheses) around everything after the first
colon to answer the question “does this do what it means?” without having to
refer to a precedence table. (Yeah, it does do what it means here…)

https://codereview.chromium.org/2710103003/diff/1/chrome/browser/ui/cocoa/too...
File chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm (right):

https://codereview.chromium.org/2710103003/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm:230: : provider &&
provider->ShouldIncreaseContrast()
Same.

[Elly Fong-Jones, 2017-02-23 17:19:42]

https://codereview.chromium.org/2710103003/diff/1/chrome/browser/ui/cocoa/too...
File chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm (right):

https://codereview.chromium.org/2710103003/diff/1/chrome/browser/ui/cocoa/too...
chrome/browser/ui/cocoa/toolbar/toolbar_button_cocoa.mm:230: : provider &&
provider->ShouldIncreaseContrast()
On 2017/02/23 01:54:16, Mark Mentovai wrote:
> Same.

Done.

[Elly Fong-Jones, 2017-02-23 17:19:50]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2017-02-23 17:19:50]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2710103003/#ps20001
(title: "add some parens")

[commit-bot: I haz the power, 2017-02-23 17:20:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 17:50:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487870390210070,
"parent_rev": "f673f4c59c985aa8ddfab2b3821c42af25d915e4", "commit_rev":
"f74bb3ef462cccad2c007d934c21b730c8d9bf08"}

[commit-bot: I haz the power, 2017-02-23 17:51:02]

Description was changed from

==========
cocoa: darken toolbar buttons in Increase Contrast mode

BUG=687227
==========

to

==========
cocoa: darken toolbar buttons in Increase Contrast mode

BUG=687227

Review-Url: https://codereview.chromium.org/2710103003
Cr-Commit-Position: refs/heads/master@{#452544}
Committed:
https://chromium.googlesource.com/chromium/src/+/f74bb3ef462cccad2c007d934c21...
==========

[commit-bot: I haz the power, 2017-02-23 17:51:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f74bb3ef462cccad2c007d934c21...