Rename tracingMetric histograms to hacker_style.

Rename tracingMetric histograms to hacker_style.

This style is more consistent with the other metrics.
Some of the previous names are moved to Histogram.description.

BUG=catapult:#3233

Review-Url: https://codereview.chromium.org/2710093005
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4c3dbb5cccad3b0ff1e5ddcb0538556f49def0fb

[benjhayden, 2017-02-23 17:54:35]

Patchset #1 (id:1) has been deleted

[benjhayden, 2017-02-23 17:54:43]

Patchset #1 (id:20001) has been deleted

[benjhayden, 2017-02-23 17:56:50]

benjhayden@chromium.org changed reviewers:
+ charliea@chromium.org, eakuefner@chromium.org, zhenw@chromium.org

[benjhayden, 2017-02-23 17:56:51]

PTAL :-)

[benjhayden, 2017-02-23 17:57:05]

Description was changed from

==========
Rename tracingMetric histograms to hacker_style.

BUG=catapult:#3233
==========

to

==========
Rename tracingMetric histograms to hacker_style.

This style is more consistent with the other metrics.

BUG=catapult:#3233
==========

[benjhayden, 2017-02-23 17:57:30]

Description was changed from

==========
Rename tracingMetric histograms to hacker_style.

This style is more consistent with the other metrics.

BUG=catapult:#3233
==========

to

==========
Rename tracingMetric histograms to hacker_style.

This style is more consistent with the other metrics.
Some of the previous names are moved to Histogram.description.

BUG=catapult:#3233
==========

[eakuefner, 2017-02-23 18:09:18]

lgtm, thanks for doing this cleanup. can you propose an update to the style
guide (and possibly h-t-w-m) as well?

[benjhayden, 2017-02-23 18:26:46]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2017-02-23 18:26:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 18:49:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 18:49:03]

Failed to apply patch for tracing/tracing/metrics/tracing_metric_test.html:
While running git apply --index -p1;
  error: patch failed: tracing/tracing/metrics/tracing_metric_test.html:138
  error: tracing/tracing/metrics/tracing_metric_test.html: patch does not apply

Patch:       tracing/tracing/metrics/tracing_metric_test.html
Index: tracing/tracing/metrics/tracing_metric_test.html
diff --git a/tracing/tracing/metrics/tracing_metric_test.html
b/tracing/tracing/metrics/tracing_metric_test.html
index
94082930453aa1df592bf6bf93c836346dd9f768..dccb8610401b884f53d05401df4eb36be694eea7
100644
--- a/tracing/tracing/metrics/tracing_metric_test.html
+++ b/tracing/tracing/metrics/tracing_metric_test.html
@@ -60,7 +60,7 @@ tr.b.unittest.testSuite(function() {
     tr.metrics.tracingMetric(histograms, model);
 
     var eventStringSize = getEventStringSize(events, [0, 1]);
-    var histogram = histograms.getHistogramNamed('Total trace size in bytes');
+    var histogram = histograms.getHistogramNamed('trace_size');
     assert.strictEqual(histogram.average, eventStringSize);
   });
 
@@ -79,13 +79,11 @@ tr.b.unittest.testSuite(function() {
     tr.metrics.tracingMetric(histograms, model);
 
     var maxEventCountPerSec = 3;
-    var histogram = histograms.getHistogramNamed(
-        'Max number of events per second');
+    var histogram = histograms.getHistogramNamed('peak_event_rate');
     assert.strictEqual(histogram.average, maxEventCountPerSec);
 
     var maxEventBytesPerSec = getEventStringSize(events, [2, 3, 5]);
-    histogram = histograms.getHistogramNamed(
-        'Max event size in bytes per second');
+    histogram = histograms.getHistogramNamed('peak_event_size_rate');
     assert.strictEqual(histogram.average, maxEventBytesPerSec);
   });
 
@@ -138,26 +136,19 @@ tr.b.unittest.testSuite(function() {
         slice => slice['cat'] === MEMORY_INFRA_TRACING_CATEGORY).reduce(
         (acc, slice) => acc + JSON.stringify(slice).length, 0);
     var totalSizeHistogram = histograms.getHistogramNamed(
-        'Total trace size of memory-infra dumps in bytes');
+        'total_memory_dump_size');
     assert.strictEqual(totalSizeHistogram.average, memoryCategorySize);
     var sizePerDumpHistogram = histograms.getHistogramNamed(
-        'Average trace size of memory-infra dumps in bytes');
+        'memory_dump_size');
     assert.strictEqual(sizePerDumpHistogram.average, memoryCategorySize);
 
-    checkDurationHistogram(histograms,
-        'Average CPU overhead of mdp1 per OnMemoryDump call', 6.5);
-    checkDurationHistogram(histograms,
-        'Average CPU overhead of mdp2 per OnMemoryDump call', 16);
-    checkDurationHistogram(histograms,
-        'Average CPU overhead of mdp3 per OnMemoryDump call', 6);
-    checkDurationHistogram(histograms,
-        'Average CPU overhead of mdp4 per OnMemoryDump call', 8);
-    checkDurationHistogram(histograms,
-        'Average CPU overhead on non-memory-infra threads per memory-infra ' +
-            'dump',
-        47);
-    checkDurationHistogram(histograms,
-        'Average CPU overhead on all threads per memory-infra dump', 91);
+    checkDurationHistogram(histograms, 'mdp1_memory_dump_cpu_overhead', 6.5);
+    checkDurationHistogram(histograms, 'mdp2_memory_dump_cpu_overhead', 16);
+    checkDurationHistogram(histograms, 'mdp3_memory_dump_cpu_overhead', 6);
+    checkDurationHistogram(histograms, 'mdp4_memory_dump_cpu_overhead', 8);
+    checkDurationHistogram(
+        histograms, 'nonmemory_thread_memory_dump_cpu_overhead', 47);
+    checkDurationHistogram(histograms, 'memory_dump_cpu_overhead', 91);
   });
 });
 </script>

[benjhayden, 2017-02-23 19:02:58]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2017-02-23 19:02:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org
Link to the patchset: https://codereview.chromium.org/2710093005/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-23 19:03:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 19:24:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487876578623240,
"parent_rev": "7ae2fc0ef449a95e3f544666918841d899f52a9a", "commit_rev":
"4c3dbb5cccad3b0ff1e5ddcb0538556f49def0fb"}

[commit-bot: I haz the power, 2017-02-23 19:24:59]

Description was changed from

==========
Rename tracingMetric histograms to hacker_style.

This style is more consistent with the other metrics.
Some of the previous names are moved to Histogram.description.

BUG=catapult:#3233
==========

to

==========
Rename tracingMetric histograms to hacker_style.

This style is more consistent with the other metrics.
Some of the previous names are moved to Histogram.description.

BUG=catapult:#3233

Review-Url: https://codereview.chromium.org/2710093005
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-02-23 19:24:59]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[charliea (OOO until 10-5), 2017-02-23 20:21:57]

after-the-fact lgtm w/ nits

https://codereview.chromium.org/2710093005/diff/60001/tracing/tracing/metrics...
File tracing/tracing/metrics/tracing_metric.html (right):

https://codereview.chromium.org/2710093005/diff/60001/tracing/tracing/metrics...
tracing/tracing/metrics/tracing_metric.html:80: providerName +
'_memory_dump_cpu_overhead',
nit: this might be a good candidate for a template function, e.g.

    ...
    `${providerName}_memory_dump_cpu_overhead`,
    overhead.duration / overhead.count, histograms,
    ...

https://codereview.chromium.org/2710093005/diff/60001/tracing/tracing/metrics...
tracing/tracing/metrics/tracing_metric.html:91: 'Total trace size of
memory-infra dumps in bytes';
nit: this should be indented by four spaces instead of two

(why the hell didn't eslint catch this? grumble grumble)