Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2710053003:
Keep a TaskScheduler instance in RenderWidgetHostViewGuestTest (Closed)
DescriptionKeep a TaskScheduler instance in RenderWidgetHostViewGuestTest
RenderWidgetHostImpl on Windows uses TaskScheduler in its constructor,
and that requires a TaskScheduler instance.
This CL add one to RenderWidgetHostViewGuestTest, so that it unbreak
the test failure on Windows bots.
BUG=695375
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Review-Url: https://codereview.chromium.org/2710053003
Cr-Commit-Position: refs/heads/master@{#452696}
Committed: https://chromium.googlesource.com/chromium/src/+/33237fadcbda24bd31d2a166ba9a79c994671dda
Patch Set 1 #Patch Set 2 : fix #
Total comments: 2
Patch Set 3 : +comment #Messages
Total messages: 20 (15 generated)
Description was changed from ========== . BUG= ========== to ========== . BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== . BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Keep a TaskScheduler instance in RenderWidgetHostViewGuestTest RenderWidgetHostImpl on Windows uses TaskScheduler in its constructor, and that requires a TaskScheduler instance. This CL add one to RenderWidgetHostViewGuestTest, so that it unbreak the test failure on Windows bots. BUG=695375 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ==========
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Patchset #2 (id:20001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tzik@chromium.org changed reviewers: + alexmos@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tzik@chromium.org changed reviewers: + clamy@chromium.org
LGTM, thanks for fixing! https://codereview.chromium.org/2710053003/diff/40001/content/browser/frame_h... File content/browser/frame_host/render_widget_host_view_guest_unittest.cc (right): https://codereview.chromium.org/2710053003/diff/40001/content/browser/frame_h... content/browser/frame_host/render_widget_host_view_guest_unittest.cc:100: base::test::ScopedTaskScheduler task_scheduler_; Perhaps also add a quick comment here why this is needed?
https://codereview.chromium.org/2710053003/diff/40001/content/browser/frame_h... File content/browser/frame_host/render_widget_host_view_guest_unittest.cc (right): https://codereview.chromium.org/2710053003/diff/40001/content/browser/frame_h... content/browser/frame_host/render_widget_host_view_guest_unittest.cc:100: base::test::ScopedTaskScheduler task_scheduler_; On 2017/02/23 22:31:54, alexmos wrote: > Perhaps also add a quick comment here why this is needed? Done.
The CQ bit was checked by tzik@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from alexmos@chromium.org Link to the patchset: https://codereview.chromium.org/2710053003/#ps60001 (title: "+comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487893788534920,
"parent_rev": "10aaaf5a41d02653d144a4e78c43c29974860e39", "commit_rev":
"33237fadcbda24bd31d2a166ba9a79c994671dda"}
Message was sent while issue was closed.
Description was changed from ========== Keep a TaskScheduler instance in RenderWidgetHostViewGuestTest RenderWidgetHostImpl on Windows uses TaskScheduler in its constructor, and that requires a TaskScheduler instance. This CL add one to RenderWidgetHostViewGuestTest, so that it unbreak the test failure on Windows bots. BUG=695375 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation ========== to ========== Keep a TaskScheduler instance in RenderWidgetHostViewGuestTest RenderWidgetHostImpl on Windows uses TaskScheduler in its constructor, and that requires a TaskScheduler instance. This CL add one to RenderWidgetHostViewGuestTest, so that it unbreak the test failure on Windows bots. BUG=695375 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2710053003 Cr-Commit-Position: refs/heads/master@{#452696} Committed: https://chromium.googlesource.com/chromium/src/+/33237fadcbda24bd31d2a166ba9a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/33237fadcbda24bd31d2a166ba9a... |
