Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2710043002: [Mac] Ensure security state label doesn't overlap divider (Closed)

Created:
3 years, 10 months ago by lgrey
Modified:
3 years, 10 months ago
Reviewers:
Robert Sesek, shrike
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Ensure security state label doesn't overlap divider See bug for screenshots BUG=647014 Review-Url: https://codereview.chromium.org/2710043002 Cr-Commit-Position: refs/heads/master@{#452499} Committed: https://chromium.googlesource.com/chromium/src/+/2f8ae52186762d312b8fbbf44043ced4ef6a333c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 3 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
lgrey
PTAL :)
3 years, 10 months ago (2017-02-22 18:44:12 UTC) #3
shrike
lgtm
3 years, 10 months ago (2017-02-22 23:21:09 UTC) #4
lgrey
Thanks! Robert PTAL for OWNERS :)
3 years, 10 months ago (2017-02-22 23:26:54 UTC) #6
Robert Sesek
lgtm
3 years, 10 months ago (2017-02-23 15:11:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2710043002/1
3 years, 10 months ago (2017-02-23 15:30:56 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 15:51:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2f8ae52186762d312b8fbbf44043...

Powered by Google App Engine
This is Rietveld 408576698