Move NetworkStateNotifier from core (and web) into platform/network

Move NetworkStateNotifier from core (and web) into platform/network

BUG=691566
Review-Url: https://codereview.chromium.org/2710023006
Cr-Commit-Position: refs/heads/master@{#455376}
Committed: https://chromium.googlesource.com/chromium/src/+/fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1

[kinuko, 2017-02-24 11:55:54]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 11:56:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-02-24 15:05:49]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 15:05:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinuko, 2017-02-24 15:07:36]

Description was changed from

==========
Move NetworkStateNotifier from core/page into platform/network

BUG=691566
==========

to

==========
Move NetworkStateNotifier from core (and web) into platform/network

BUG=691566
==========

[commit-bot: I haz the power, 2017-02-24 16:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 16:08:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kinuko, 2017-03-03 10:05:38]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 10:05:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 11:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 11:35:18]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-03-06 06:30:59]

kinuko@chromium.org changed reviewers:
+ boliu@chromium.org, dcheng@chromium.org, jkarlin@chromium.org

[kinuko, 2017-03-06 06:34:30]

Hopefully the last change in this series, mostly mechanical only. PTL

jkarlin@: owner review

boliu@: android_webview owner review

dcheng@: overall blink review

Thanks!

[sof, 2017-03-06 06:43:03]

https://codereview.chromium.org/2710023006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
(right):

https://codereview.chromium.org/2710023006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp:298:
m_notifier.removeConnectionObserver(&observer2, getTaskRunner());
getTaskRunner2()

[sof, 2017-03-06 06:53:21]

https://codereview.chromium.org/2710023006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
(right):

https://codereview.chromium.org/2710023006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp:298:
m_notifier.removeConnectionObserver(&observer2, getTaskRunner());
On 2017/03/06 06:43:03, sof wrote:
> getTaskRunner2() 

..but why are explicit removals now needed?

[kinuko, 2017-03-06 06:56:22]

On 2017/03/06 06:53:21, sof wrote:
>
https://codereview.chromium.org/2710023006/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
> (right):
> 
>
https://codereview.chromium.org/2710023006/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp:298:
> m_notifier.removeConnectionObserver(&observer2, getTaskRunner());
> On 2017/03/06 06:43:03, sof wrote:
> > getTaskRunner2() 

Gush, thanks for catching.

> ..but why are explicit removals now needed?

The observer list stores task runner refs, and they're leaked otherwise.

[kinuko, 2017-03-06 07:39:02]

https://codereview.chromium.org/2710023006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp
(right):

https://codereview.chromium.org/2710023006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/network/NetworkStateNotifierTest.cpp:298:
m_notifier.removeConnectionObserver(&observer2, getTaskRunner());
On 2017/03/06 06:43:03, sof wrote:
> getTaskRunner2() 

Done.

[kinuko, 2017-03-06 07:39:12]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 07:39:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 09:07:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 09:07:08]

Dry run: This issue passed the CQ dry run.

[jkarlin, 2017-03-06 15:52:02]

lgtm!

[boliu, 2017-03-06 17:11:58]

lgtm

[dcheng, 2017-03-06 21:57:52]

lgtm

[kinuko, 2017-03-07 04:50:31]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:51:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 04:55:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:55:56]

Failed to apply patch for
third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp:10
  error: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp: patch does
not apply

Patch:       third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
Index: third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
diff --git a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
index
2052be4281eb6fdfd907cd8468251f17e01831ad..bb3e78c6f70937a7eb388f34c3e789a07be71d63
100644
--- a/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
+++ b/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
@@ -10,13 +10,13 @@
 #include "core/dom/Document.h"
 #include "core/frame/LocalFrameClient.h"
 #include "core/inspector/ConsoleMessage.h"
-#include "core/page/NetworkStateNotifier.h"
 #include "platform/Histogram.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/fonts/FontCache.h"
 #include "platform/fonts/FontDescription.h"
 #include "platform/fonts/SimpleFontData.h"
 #include "platform/loader/fetch/ResourceFetcher.h"
+#include "platform/network/NetworkStateNotifier.h"
 #include "platform/network/ResourceLoadPriority.h"
 #include "public/platform/WebEffectiveConnectionType.h"
 #include "wtf/CurrentTime.h"

[kinuko, 2017-03-07 06:28:07]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-03-07 06:28:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkarlin@chromium.org, boliu@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2710023006/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-07 06:28:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 08:03:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:03:05]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kinuko, 2017-03-07 08:34:54]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-03-07 08:35:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 10:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 10:36:26]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kinuko, 2017-03-08 01:40:01]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-03-08 01:41:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 04:01:10]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488937201037350,
"parent_rev": "32a1d4fe89cae285d45590f12eea9ec54102efd6", "commit_rev":
"fbfee7609c1c5572f43622a4cbb0bd9313ccc8a1"}

[commit-bot: I haz the power, 2017-03-08 04:01:52]

Description was changed from

==========
Move NetworkStateNotifier from core (and web) into platform/network

BUG=691566
==========

to

==========
Move NetworkStateNotifier from core (and web) into platform/network

BUG=691566

Review-Url: https://codereview.chromium.org/2710023006
Cr-Commit-Position: refs/heads/master@{#455376}
Committed:
https://chromium.googlesource.com/chromium/src/+/fbfee7609c1c5572f43622a4cbb0...
==========

[commit-bot: I haz the power, 2017-03-08 04:01:54]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fbfee7609c1c5572f43622a4cbb0...