third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h - Issue 2709983004: WIP bindings: Add support for the record<K,V> WebIDL type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h

Issue 2709983004: WIP bindings: Add support for the record<K,V> WebIDL type. (Closed)

Patch Set: Rebased patch using NativeValueTraits for IDL types Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h

index ec4a36051dd29614335f09e6665043e219d88bbe..cd7054f7048c364ecfe43c0c45e9b836bb6a0348 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h

@@ -41,7 +41,8 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestDictionaryDer

template <>

struct NativeValueTraits<TestDictionaryDerivedImplementedAs> {

- static TestDictionaryDerivedImplementedAs nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);

+ using ImplType = TestDictionaryDerivedImplementedAs;

+ CORE_EXPORT static TestDictionaryDerivedImplementedAs nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);

};

template <>