Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1487)

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl

Issue 2709983004: WIP bindings: Add support for the record<K,V> WebIDL type. (Closed)
Patch Set: Rebased patch using NativeValueTraits for IDL types Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl
diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl b/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl
index 3681457ff617e2e3b26598259dc3fa4203869a66..b825a8e20868867a94f1eddd694343f9f6182736 100644
--- a/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl
+++ b/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl
@@ -31,7 +31,8 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}& im
template <>
struct NativeValueTraits<{{cpp_class}}> {
- static {{cpp_class}} nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
+ using ImplType = {{cpp_class}};
Yuki 2017/03/02 07:47:28 nit: Can we have this declaration as the default d
Raphael Kubo da Costa (rakuco) 2017/03/02 08:16:24 I tried doing that earlier, but any template speci
Yuki 2017/03/02 13:00:25 I guess that the following would work. template
+ {{exported}}static {{cpp_class}} nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);
};
template <>

Powered by Google App Engine
This is Rietveld 408576698