third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h - Issue 2709983004: WIP bindings: Add support for the record<K,V> WebIDL type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

Issue 2709983004: WIP bindings: Add support for the record<K,V> WebIDL type. (Closed)

Patch Set: Rebased patch using NativeValueTraits for IDL types Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

index da84d23de361ecfc6172b39ebe990399bb54e502..23fd09d9fd51b0aeee6552eeb7d5fd4c67b7c159 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

@@ -41,7 +41,8 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestDictionary& i

template <>

struct NativeValueTraits<TestDictionary> {

- static TestDictionary nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);

+ using ImplType = TestDictionary;

+ CORE_EXPORT static TestDictionary nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);

};

template <>