third_party/WebKit/Source/core/editing/Editor.cpp - Issue 2709973005: Get rid of useless function VisibleSelection::updateIfNeeded()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/Editor.cpp

Issue 2709973005: Get rid of useless function VisibleSelection::updateIfNeeded() (Closed)

Patch Set: 2017-02-25T10:01:23 Do not remove FrameSelection::updateIfNeeded() Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/Editor.cpp

diff --git a/third_party/WebKit/Source/core/editing/Editor.cpp b/third_party/WebKit/Source/core/editing/Editor.cpp

index 147b10fa09c203c7d4978f25893ff29ef469de4d..99b128a2f4d99c14206072550ed2355fefbd75ac 100644

--- a/third_party/WebKit/Source/core/editing/Editor.cpp

+++ b/third_party/WebKit/Source/core/editing/Editor.cpp

@@ -926,9 +926,7 @@ static VisibleSelection correctedVisibleSelection(

!passedSelection.extent().isConnected())

return VisibleSelection();

DCHECK(!passedSelection.base().document()->needsLayoutTreeUpdate());

- VisibleSelection correctedSelection = passedSelection;

- correctedSelection.updateIfNeeded();

- return correctedSelection;

+ return createVisibleSelection(passedSelection.asSelection());

}

void Editor::unappliedEditing(UndoStep* cmd) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/VisibleSelection.h » ('j') | no next file with comments »