Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1417)

Issue 2709973003: [Payment Request] Updates iOS watchlist (Closed)

Created:
3 years, 3 months ago by Moe
Modified:
3 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Updates iOS watchlist Review-Url: https://codereview.chromium.org/2709973003 Cr-Commit-Position: refs/heads/master@{#452158} Committed: https://chromium.googlesource.com/chromium/src/+/0a7bb59fff7ca4ba57577a4dcf3e013019f5794b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added self to 'payments' watch list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M WATCHLISTS View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Moe
Hi Rouslan. PTAL.
3 years, 3 months ago (2017-02-22 14:53:59 UTC) #2
please use gerrit instead
https://codereview.chromium.org/2709973003/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2709973003/diff/1/WATCHLISTS#newcode822 WATCHLISTS:822: '|ios/web/public/payments/'\ Does iOS use components/payments/ ?
3 years, 3 months ago (2017-02-22 15:07:14 UTC) #3
Moe
https://codereview.chromium.org/2709973003/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2709973003/diff/1/WATCHLISTS#newcode822 WATCHLISTS:822: '|ios/web/public/payments/'\ On 2017/02/22 15:07:13, rouslan wrote: > Does iOS ...
3 years, 3 months ago (2017-02-22 15:12:26 UTC) #4
please use gerrit instead
LGTM % comment: I recommend adding "components/payments/currency_formatter" to the payments_ios watchlist. Since iOS uses that ...
3 years, 3 months ago (2017-02-22 15:15:57 UTC) #5
Moe
Thanks Rouslan, I added myself to the 'payments' watchlist as well to keep up-to-date wit ...
3 years, 3 months ago (2017-02-22 18:47:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709973003/20001
3 years, 3 months ago (2017-02-22 18:50:16 UTC) #9
commit-bot: I haz the power
3 years, 3 months ago (2017-02-22 19:14:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0a7bb59fff7ca4ba57577a4dcf3e...

Powered by Google App Engine
This is Rietveld 408576698