Remove gconf usage from atk_util_auralinux

Remove gconf usage from atk_util_auralinux

Excerpt from https://developer.gnome.org/accessibility-devel-guide/stable/gad-how-it-works.html.en
Whether or not applications on the GNOME desktop automatically load
these accessibility support libraries depends on the value of a gconf
key, "/desktop/gnome/interface/accessibility"; a boolean value of
"true" enables support for assistive technologies and applications
which call gnome_program_init will automatically load the appropriate
accessibility libraries at runtime. "Pure GTK+ applications",
e.g. those that use gtk+ but do not link to libgnome, rely on the
value of the GTK_MODULES environment variable, which must be set to
"gail:atk-bridge" in order to enable assistive technology support.

This CL changes Chromium to determine it's accessibility preferences
from the GTK_MODULES variable rather than the
/desktop/gnome/interface/accessibility gconf key.  This has the added
advantage of being desktop-agnostic, so now accessibility settings
should be recognized on more environments than just Gnome.

BUG=693668, 695643
TBR=aboxhall@chromium.org
R=thestig@chromium.org
CC=dpranke@chromium.org,primiano@chromium.org

Review-Url: https://codereview.chromium.org/2709963004
Cr-Commit-Position: refs/heads/master@{#452735}
Committed: https://chromium.googlesource.com/chromium/src/+/56741ec45a112dcf94dc8d2d571646a2210e367c

[Tom (Use chromium acct), 2017-02-24 00:41:30]

lei ptal

[Tom (Use chromium acct), 2017-02-24 00:43:44]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[Lei Zhang, 2017-02-24 00:44:20]

thestig@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[Lei Zhang, 2017-02-24 00:44:21]

Look ok, but I'm not an owner here. +dmazzoni.

[commit-bot: I haz the power, 2017-02-24 00:44:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-02-24 01:24:07]

lgtm

Thanks, this is great

I think you can also remove the dependency on gconf
from ui/accessibility/BUILD.gn

https://codereview.chromium.org/2709963004/diff/1/ui/accessibility/platform/a...
File ui/accessibility/platform/atk_util_auralinux.cc (right):

https://codereview.chromium.org/2709963004/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/atk_util_auralinux.cc:52: const char kGtkModules[] =
"GTK_MODULES";
Maybe put these at the top where the other constants are now?

https://codereview.chromium.org/2709963004/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/atk_util_auralinux.cc:69: const char
kAccessibilityEnabled[] = "ACCESSIBILITY_ENABLED";
same, move to top

[Tom (Use chromium acct), 2017-02-24 01:44:17]

On 2017/02/24 01:24:07, dmazzoni wrote:
> lgtm
> 
> Thanks, this is great
> 
> I think you can also remove the dependency on gconf
> from ui/accessibility/BUILD.gn
> 

Done.

https://codereview.chromium.org/2709963004/diff/1/ui/accessibility/platform/a...
File ui/accessibility/platform/atk_util_auralinux.cc (right):

https://codereview.chromium.org/2709963004/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/atk_util_auralinux.cc:52: const char kGtkModules[] =
"GTK_MODULES";
On 2017/02/24 01:24:07, dmazzoni wrote:
> Maybe put these at the top where the other constants are now?

Done.

https://codereview.chromium.org/2709963004/diff/1/ui/accessibility/platform/a...
ui/accessibility/platform/atk_util_auralinux.cc:69: const char
kAccessibilityEnabled[] = "ACCESSIBILITY_ENABLED";
On 2017/02/24 01:24:07, dmazzoni wrote:
> same, move to top

Done.

[Tom (Use chromium acct), 2017-02-24 01:44:26]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-02-24 01:44:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2709963004/#ps20001
(title: "Remove gconf config, move constants to top")

[commit-bot: I haz the power, 2017-02-24 01:44:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 03:17:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487900666557170,
"parent_rev": "e07e958d62db5bb606c0dbbb446d2a25e33c3db1", "commit_rev":
"56741ec45a112dcf94dc8d2d571646a2210e367c"}

[commit-bot: I haz the power, 2017-02-24 03:17:43]

Description was changed from

==========
Remove gconf usage from atk_util_auralinux

Excerpt from
https://developer.gnome.org/accessibility-devel-guide/stable/gad-how-it-works...
Whether or not applications on the GNOME desktop automatically load
these accessibility support libraries depends on the value of a gconf
key, "/desktop/gnome/interface/accessibility"; a boolean value of
"true" enables support for assistive technologies and applications
which call gnome_program_init will automatically load the appropriate
accessibility libraries at runtime. "Pure GTK+ applications",
e.g. those that use gtk+ but do not link to libgnome, rely on the
value of the GTK_MODULES environment variable, which must be set to
"gail:atk-bridge" in order to enable assistive technology support.

This CL changes Chromium to determine it's accessibility preferences
from the GTK_MODULES variable rather than the
/desktop/gnome/interface/accessibility gconf key.  This has the added
advantage of being desktop-agnostic, so now accessibility settings
should be recognized on more environments than just Gnome.

BUG=693668,695643

TBR=aboxhall@chromium.org
R=thestig@chromium.org
CC=dpranke@chromium.org,primiano@chromium.org
==========

to

==========
Remove gconf usage from atk_util_auralinux

Excerpt from
https://developer.gnome.org/accessibility-devel-guide/stable/gad-how-it-works...
Whether or not applications on the GNOME desktop automatically load
these accessibility support libraries depends on the value of a gconf
key, "/desktop/gnome/interface/accessibility"; a boolean value of
"true" enables support for assistive technologies and applications
which call gnome_program_init will automatically load the appropriate
accessibility libraries at runtime. "Pure GTK+ applications",
e.g. those that use gtk+ but do not link to libgnome, rely on the
value of the GTK_MODULES environment variable, which must be set to
"gail:atk-bridge" in order to enable assistive technology support.

This CL changes Chromium to determine it's accessibility preferences
from the GTK_MODULES variable rather than the
/desktop/gnome/interface/accessibility gconf key.  This has the added
advantage of being desktop-agnostic, so now accessibility settings
should be recognized on more environments than just Gnome.

BUG=693668,695643

TBR=aboxhall@chromium.org
R=thestig@chromium.org
CC=dpranke@chromium.org,primiano@chromium.org

Review-Url: https://codereview.chromium.org/2709963004
Cr-Commit-Position: refs/heads/master@{#452735}
Committed:
https://chromium.googlesource.com/chromium/src/+/56741ec45a112dcf94dc8d2d5716...
==========

[commit-bot: I haz the power, 2017-02-24 03:17:44]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/56741ec45a112dcf94dc8d2d5716...