Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 2709953002: [turbofan] Fix a copy/paste error in MarkerIs[Not]FrameType (Closed)

Created:
3 years, 10 months ago by Leszek Swirski
Modified:
3 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix a copy/paste error in MarkerIs[Not]FrameType Make MarkerIs[Not]FrameType actually use their argument instead of a fixed value for the stack frame type. Review-Url: https://codereview.chromium.org/2709953002 Cr-Commit-Position: refs/heads/master@{#43454} Committed: https://chromium.googlesource.com/v8/v8/+/1ac4eb21f5ddbe0c0983b9c43390ba22d48c97bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Leszek Swirski
Hey Benedikt, Just noticed this stupid mistake while looking at something else -- whoops :)
3 years, 10 months ago (2017-02-22 10:19:32 UTC) #4
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-02-22 10:34:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709953002/1
3 years, 10 months ago (2017-02-22 10:35:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709953002/1
3 years, 9 months ago (2017-02-27 15:23:47 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 15:47:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1ac4eb21f5ddbe0c0983b9c43390ba22d48...

Powered by Google App Engine
This is Rietveld 408576698