Chromium Code Reviews| Index: ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm |
| diff --git a/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm b/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm |
| index 2101964d24e869103647dbd2bad3b2520181af46..a0269ba78a9bc64351bc895990472bd7f893ddbc 100644 |
| --- a/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm |
| +++ b/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm |
| @@ -41,7 +41,9 @@ const CGFloat kViewportBorderShadowOpacity = 1.0; |
| // Shadow radius of the viewport border. |
| const CGFloat kViewportBorderShadowRadius = 10.0; |
| // Padding of the viewport caption, below the viewport. |
| -const CGFloat kViewportCaptionPadding = 24.0; |
| +const CGFloat kViewportCaptionVerticalPadding = 14.0; |
| +// Padding of the viewport caption from the edges of the superview. |
| +const CGFloat kViewportCaptionHorizontalPadding = 20.0; |
| // Shadow opacity of the viewport caption. |
| const CGFloat kViewportCaptionShadowOpacity = 1.0; |
| // Shadow radius of the viewport caption. |
| @@ -470,6 +472,8 @@ CGFloat GetViewportSize() { |
| UILabel* viewportCaption = [[[UILabel alloc] init] autorelease]; |
| NSString* label = l10n_util::GetNSString(IDS_IOS_QR_SCANNER_VIEWPORT_CAPTION); |
| [viewportCaption setText:label]; |
| + [viewportCaption setNumberOfLines:0]; |
| + [viewportCaption setTextAlignment:NSTextAlignmentCenter]; |
| [viewportCaption setAccessibilityLabel:label]; |
| [viewportCaption setAccessibilityIdentifier:@"qr_scanner_viewport_caption"]; |
| [viewportCaption setTextColor:[UIColor whiteColor]]; |
| @@ -484,11 +488,16 @@ CGFloat GetViewportSize() { |
| // Constraints for viewportCaption. |
| [viewportCaption setTranslatesAutoresizingMaskIntoConstraints:NO]; |
| [NSLayoutConstraint activateConstraints:@[ |
| - [[viewportCaption centerXAnchor] |
| - constraintEqualToAnchor:[self centerXAnchor]], |
| - [[viewportCaption centerYAnchor] |
| + [[viewportCaption topAnchor] |
| constraintEqualToAnchor:[self centerYAnchor] |
| - constant:GetViewportSize() / 2 + kViewportCaptionPadding] |
| + constant:GetViewportSize() / 2 + |
| + kViewportCaptionVerticalPadding], |
| + [viewportCaption.leftAnchor |
|
gambard
2017/02/22 12:43:48
I am not sure about how left/right anchor are trea
jif
2017/02/22 12:59:07
Done.
|
| + constraintEqualToAnchor:self.leftAnchor |
| + constant:kViewportCaptionHorizontalPadding], |
| + [viewportCaption.rightAnchor |
| + constraintEqualToAnchor:self.rightAnchor |
| + constant:-kViewportCaptionHorizontalPadding], |
| ]]; |
| } |