Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2709943002: Make the QR Code scanner caption fit on multiple lines. (Closed)

Created:
3 years, 10 months ago by jif
Modified:
3 years, 10 months ago
Reviewers:
gambard
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the QR Code scanner caption fit on multiple lines. BUG=694739 Review-Url: https://codereview.chromium.org/2709943002 Cr-Commit-Position: refs/heads/master@{#452022} Committed: https://chromium.googlesource.com/chromium/src/+/3974d9eded98f5261afbc2b4315f0c22fdd10072

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comment. #

Total comments: 2

Patch Set 3 : AC #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm View 1 2 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
jif
ptal
3 years, 10 months ago (2017-02-22 10:06:30 UTC) #4
gambard
https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm File ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm (right): https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm#newcode493 ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:493: [[viewportCaption topAnchor] Don't we want to just align on ...
3 years, 10 months ago (2017-02-22 10:49:04 UTC) #5
jif
thanks. ptal https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm File ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm (right): https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm#newcode493 ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:493: [[viewportCaption topAnchor] On 2017/02/22 10:49:04, gambard wrote: ...
3 years, 10 months ago (2017-02-22 12:42:15 UTC) #7
gambard
https://codereview.chromium.org/2709943002/diff/60001/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm File ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm (right): https://codereview.chromium.org/2709943002/diff/60001/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm#newcode495 ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:495: [viewportCaption.leftAnchor I am not sure about how left/right anchor ...
3 years, 10 months ago (2017-02-22 12:43:48 UTC) #8
jif
https://codereview.chromium.org/2709943002/diff/60001/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm File ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm (right): https://codereview.chromium.org/2709943002/diff/60001/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm#newcode495 ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:495: [viewportCaption.leftAnchor On 2017/02/22 12:43:48, gambard wrote: > I am ...
3 years, 10 months ago (2017-02-22 12:59:07 UTC) #9
gambard
lgtm :)
3 years, 10 months ago (2017-02-22 12:59:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709943002/80001
3 years, 10 months ago (2017-02-22 13:00:11 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 13:12:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3974d9eded98f5261afbc2b4315f...

Powered by Google App Engine
This is Rietveld 408576698