|
|
Created:
3 years, 10 months ago by jif Modified:
3 years, 10 months ago Reviewers:
gambard CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake the QR Code scanner caption fit on multiple lines.
BUG=694739
Review-Url: https://codereview.chromium.org/2709943002
Cr-Commit-Position: refs/heads/master@{#452022}
Committed: https://chromium.googlesource.com/chromium/src/+/3974d9eded98f5261afbc2b4315f0c22fdd10072
Patch Set 1 #
Total comments: 4
Patch Set 2 : Addressed comment. #
Total comments: 2
Patch Set 3 : AC #Messages
Total messages: 15 (7 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Make the QR Code scanner caption fit on multiple lines. BUG=694739 ========== to ========== Make the QR Code scanner caption fit on multiple lines. BUG=694739 ==========
jif@chromium.org changed reviewers: + gambard@chromium.org
ptal
https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/q... File ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm (right): https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/q... ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:493: [[viewportCaption topAnchor] Don't we want to just align on the _previewView.bottomAnchor? Or is there a scenario where the preview is not shown and we want the text to be displayed here? https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/q... ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:497: [viewportCaption.widthAnchor Why using this and not constraints on leading/trailing + constants? The result would be the same but it would be easier to read in my opinion.
Patchset #2 (id:40001) has been deleted
thanks. ptal https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/q... File ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm (right): https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/q... ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:493: [[viewportCaption topAnchor] On 2017/02/22 10:49:04, gambard wrote: > Don't we want to just align on the _previewView.bottomAnchor? Or is there a > scenario where the preview is not shown and we want the text to be displayed > here? _previewView is the view that contains the video. It takes the whole screen. What we'd need is the bottomAnchor of the transparent square, but that transparent square is not a view, so we can't use its bottomAnchor. https://codereview.chromium.org/2709943002/diff/20001/ios/chrome/browser/ui/q... ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:497: [viewportCaption.widthAnchor On 2017/02/22 10:49:04, gambard wrote: > Why using this and not constraints on leading/trailing + constants? > The result would be the same but it would be easier to read in my opinion. Done.
https://codereview.chromium.org/2709943002/diff/60001/ios/chrome/browser/ui/q... File ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm (right): https://codereview.chromium.org/2709943002/diff/60001/ios/chrome/browser/ui/q... ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:495: [viewportCaption.leftAnchor I am not sure about how left/right anchor are treated in RTL. Maybe trailing/leading would be safer?
https://codereview.chromium.org/2709943002/diff/60001/ios/chrome/browser/ui/q... File ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm (right): https://codereview.chromium.org/2709943002/diff/60001/ios/chrome/browser/ui/q... ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm:495: [viewportCaption.leftAnchor On 2017/02/22 12:43:48, gambard wrote: > I am not sure about how left/right anchor are treated in RTL. Maybe > trailing/leading would be safer? Done.
lgtm :)
The CQ bit was checked by jif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487768395458500, "parent_rev": "db28325f75a0ea04c612f93849861d01997d3aeb", "commit_rev": "3974d9eded98f5261afbc2b4315f0c22fdd10072"}
Message was sent while issue was closed.
Description was changed from ========== Make the QR Code scanner caption fit on multiple lines. BUG=694739 ========== to ========== Make the QR Code scanner caption fit on multiple lines. BUG=694739 Review-Url: https://codereview.chromium.org/2709943002 Cr-Commit-Position: refs/heads/master@{#452022} Committed: https://chromium.googlesource.com/chromium/src/+/3974d9eded98f5261afbc2b4315f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as https://chromium.googlesource.com/chromium/src/+/3974d9eded98f5261afbc2b4315f... |