Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2709923003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add COMPONENT into OWNERS files. We are adding COMPONENT information into OWNERS file (Platform>NACL related). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 Review-Url: https://codereview.chromium.org/2709923003 Cr-Commit-Position: refs/heads/master@{#452629} Committed: https://chromium.googlesource.com/chromium/src/+/44a6deddaeef50a0ea725635851008308018789d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/nacl_host/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/nacl/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/nacl/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/nacl/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/nacl_test_injection/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/loader/nonsfi/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/loader/sandbox_linux/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/nacl_irt/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-22 21:13:34 UTC) #2
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-22 21:13:36 UTC) #3
Mark Seaborn
LGTM. In the commit message, maybe change "TEAM/COMPONENT" -> "COMPONENT", and drop the "Please help ...
3 years, 10 months ago (2017-02-23 19:39:39 UTC) #4
ymzhang1
On 2017/02/23 19:39:39, Mark Seaborn wrote: > LGTM. In the commit message, maybe change "TEAM/COMPONENT" ...
3 years, 10 months ago (2017-02-23 19:44:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2709923003/1
3 years, 10 months ago (2017-02-23 19:46:41 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 21:12:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/44a6deddaeef50a0ea7256358510...

Powered by Google App Engine
This is Rietveld 408576698