ash/common/system/tray/hover_highlight_view.cc - Issue 2709903004: Consolidate some more ash tray constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/tray/hover_highlight_view.cc

Issue 2709903004: Consolidate some more ash tray constants. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/system/tray/hover_highlight_view.cc

diff --git a/ash/common/system/tray/hover_highlight_view.cc b/ash/common/system/tray/hover_highlight_view.cc

index 739810c9076559400fdefd1f6149f22c1f317918..c96f14315dc548c5ce3e9e4d578648b39e73a6fc 100644

--- a/ash/common/system/tray/hover_highlight_view.cc

+++ b/ash/common/system/tray/hover_highlight_view.cc

@@ -373,7 +373,7 @@ void HoverHighlightView::GetAccessibleNodeData(ui::AXNodeData* node_data) {

gfx::Size HoverHighlightView::GetPreferredSize() const {

gfx::Size size = ActionableView::GetPreferredSize();

- const int default_height = GetTrayConstant(TRAY_POPUP_ITEM_MIN_HEIGHT);

+ const int default_height = kTrayPopupItemMinHeight;

tdanderson 2017/02/28 17:08:18 nit: local variable not needed

Evan Stade 2017/03/01 04:28:54 Done.

if (custom_height_)

size.set_height(custom_height_);