ash/common/system/chromeos/network/network_state_list_detailed_view.cc - Issue 2709903004: Consolidate some more ash tray constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/chromeos/network/network_state_list_detailed_view.cc

Issue 2709903004: Consolidate some more ash tray constants. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/common/system/chromeos/audio/volume_view.cc ('K') | « ash/common/system/chromeos/ime_menu/ime_menu_tray.cc ('k') | ash/common/system/date/date_view.cc » ('j') | ash/common/system/tray/hover_highlight_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/common/system/chromeos/network/network_state_list_detailed_view.cc

diff --git a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc b/ash/common/system/chromeos/network/network_state_list_detailed_view.cc

index 224c07b5e20d9e8a969d32543d46fe2b3b9e0d23..646b0fdc707952ab5aa0680eaefb3eb1c5b684c4 100644

--- a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc

+++ b/ash/common/system/chromeos/network/network_state_list_detailed_view.cc

@@ -232,7 +232,7 @@ class InfoIcon : public views::ImageButton {

// views::View

gfx::Size GetPreferredSize() const override {

- int size = GetTrayConstant(TRAY_POPUP_ITEM_MIN_HEIGHT);

+ int size = kTrayPopupItemMinHeight;

return gfx::Size(size, size);

tdanderson 2017/02/28 17:08:18 nit: |size| not needed, just use constant itself a

Evan Stade 2017/03/01 04:28:54 Done.

}